Re: [PATCH net-next] net: ipv6: inet6_connection_sock.h needs flowi

[Christoph Paasch <christoph.paasch@uclouvain.be>]

On 10/17/2011 03:13 AM, David Miller wrote:
> From: Christoph Paasch<christoph.paasch@uclouvain.be>
> Date: Sun, 16 Oct 2011 12:13:39 +0300
>
>> On 10/16/2011 01:41 AM, David Miller wrote:
>>> From: Christoph Paasch<christoph.paasch@uclouvain.be>
>>> Date: Sat, 15 Oct 2011 12:34:24 +0300
>>>
>>>> Otherwise we have a compiler-warning in c-files not including
>>>> net/flow.h
>>>> before inet6_connection_sock.h .
>>>>
>>>> Signed-off-by: Christoph Paasch<christoph.paasch@uclouvain.be>
>>>
>>> Example?  I've never seen this warning.
>>
>> Currently, all the c-files that include inet6_connection_sock.h
>> indirectly include flow.h before inet6_connection_sock.h. Thus
>> currently there is no compiler-warning.
>
> Then there is no bug you are fixing.

You're right. The patch did not intend to fix a bug (maybe the 
commit-message should have been more clear about that).
It was intended to make inet6_connection_sock.h not rely on the c-files 
to include flow.h, even if they would not need to. And to do the same 
for struct flowi as it is done for the other structs in this 
header-file. Thus it was rather a coding-style patch... :)

But ok, maybe I should not try to change something which is not really 
broken... ;-)

Christoph


-- 
Christoph Paasch
PhD Student

IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp
Université Catholique de Louvain
--