From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thellstrom@vmware.com>
Date: Tue, 18 Oct 2011 06:38:22 +0000
Subject: Re: [patch] vmwgfx: information leak in vmw_execbuf_copy_fence_user()
Message-Id: <4E9D1EDE.9090207@vmware.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20111018061012.GE27732@elgon.mountain>
In-Reply-To: <20111018061012.GE27732@elgon.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, Vasiliy Kulikov <segooon@gmail.com>, dri-devel@lists.freedesktop.org, Jerome Glisse <jglisse@redhat.com>, Dave Airlie <airlied@redhat.com>

On 10/18/2011 08:10 AM, Dan Carpenter wrote:
> If ret is non-zero then we don't initialize the struct which leaks
> stack information to user space.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>    

Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index d4a1d8b..28e1c35 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -1070,6 +1070,8 @@ vmw_execbuf_copy_fence_user(struct vmw_private *dev_priv,
>   	if (user_fence_rep = NULL)
>   		return;
>
> +	memset(&fence_rep, 0, sizeof(fence_rep));
> +
>   	fence_rep.error = ret;
>   	if (ret = 0) {
>   		BUG_ON(fence = NULL);
>    


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [patch] vmwgfx: information leak in vmw_execbuf_copy_fence_user()
Date: Tue, 18 Oct 2011 08:38:22 +0200
Message-ID: <4E9D1EDE.9090207@vmware.com>
References: <20111018061012.GE27732@elgon.mountain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com
	[65.115.85.73])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1FB04A02E4
	for <dri-devel@lists.freedesktop.org>;
	Mon, 17 Oct 2011 23:40:33 -0700 (PDT)
In-Reply-To: <20111018061012.GE27732@elgon.mountain>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, Vasiliy Kulikov <segooon@gmail.com>, dri-devel@lists.freedesktop.org, Jerome Glisse <jglisse@redhat.com>, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On 10/18/2011 08:10 AM, Dan Carpenter wrote:
> If ret is non-zero then we don't initialize the struct which leaks
> stack information to user space.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>    

Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index d4a1d8b..28e1c35 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -1070,6 +1070,8 @@ vmw_execbuf_copy_fence_user(struct vmw_private *dev_priv,
>   	if (user_fence_rep == NULL)
>   		return;
>
> +	memset(&fence_rep, 0, sizeof(fence_rep));
> +
>   	fence_rep.error = ret;
>   	if (ret == 0) {
>   		BUG_ON(fence == NULL);
>