From: Wolfgang Grandegger <wg@grandegger.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org, U Bhaskar-B22300 <B22300@freescale.com>,
socketcan-core@lists.berlios.de, Robin Holt <holt@sgi.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)
Date: Tue, 18 Oct 2011 09:13:53 +0200 [thread overview]
Message-ID: <4E9D2731.4010800@grandegger.com> (raw)
In-Reply-To: <16FBAA47-5133-43A1-80CE-C6D63B79FB5D@kernel.crashing.org>
Hi Kumar,
On 10/18/2011 07:44 AM, Kumar Gala wrote:
>
> On Aug 16, 2011, at 10:32 PM, Robin Holt wrote:
>
>> David,
>>
>> The following set of patches have been reviewed by the above parties and
>> all comments have been integrated. Although the patches stray from the
>> drivers/net/can directory, the diversions are related to changes for
>> the flexcan driver.
>>
>> The patch set is based upon your net-next-2.6 tree's commit 6c37e46.
>>
>> Could you please queue these up for the next appropriate push to Linus'
>> tree?
>>
>> Thanks,
>> Robin Holt
>
> Robin,
>
> Do you remember why we went with just 'fsl,p1010-flexcan' as the device tree compatible? Do we feel the flex can on P1010 isn't the same as on MPC5xxx? or the ARM SoCs?
The MPC5xxx SOCs have a MSCAN controller, which is different to the
Flexcan and handled by another driver. But the Flexcan's on the
Freescale ARM SOCs are identical and supported by that driver as well
and "fsl,flexcan" would work *perfectly*. Actually Grant instructed use
to be more explicit and use "fsl,p1010-flexcan". Anyway,
"fsl,p1010-flexcan" should work on ARM SOCs if the source frequency is
provided via boot loader or the DTS file. Compatibility was one of our
main concerns.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)
Date: Tue, 18 Oct 2011 09:13:53 +0200 [thread overview]
Message-ID: <4E9D2731.4010800@grandegger.com> (raw)
In-Reply-To: <16FBAA47-5133-43A1-80CE-C6D63B79FB5D-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Hi Kumar,
On 10/18/2011 07:44 AM, Kumar Gala wrote:
>
> On Aug 16, 2011, at 10:32 PM, Robin Holt wrote:
>
>> David,
>>
>> The following set of patches have been reviewed by the above parties and
>> all comments have been integrated. Although the patches stray from the
>> drivers/net/can directory, the diversions are related to changes for
>> the flexcan driver.
>>
>> The patch set is based upon your net-next-2.6 tree's commit 6c37e46.
>>
>> Could you please queue these up for the next appropriate push to Linus'
>> tree?
>>
>> Thanks,
>> Robin Holt
>
> Robin,
>
> Do you remember why we went with just 'fsl,p1010-flexcan' as the device tree compatible? Do we feel the flex can on P1010 isn't the same as on MPC5xxx? or the ARM SoCs?
The MPC5xxx SOCs have a MSCAN controller, which is different to the
Flexcan and handled by another driver. But the Flexcan's on the
Freescale ARM SOCs are identical and supported by that driver as well
and "fsl,flexcan" would work *perfectly*. Actually Grant instructed use
to be more explicit and use "fsl,p1010-flexcan". Anyway,
"fsl,p1010-flexcan" should work on ARM SOCs if the source frequency is
provided via boot loader or the DTS file. Compatibility was one of our
main concerns.
Wolfgang.
next prev parent reply other threads:[~2011-10-18 7:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 3:32 [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 1/6] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 2/6] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 3/6] flexcan: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 4/6] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 5/6] flexcan: Prefer device tree clock frequency if available Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-17 3:32 ` [PATCH v13 6/6] flexcan: Add flexcan device support for p1010rdb Robin Holt
2011-08-17 3:32 ` Robin Holt
2011-08-18 3:36 ` [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010) David Miller
2011-08-18 3:36 ` David Miller
2011-10-18 5:44 ` Kumar Gala
2011-10-18 5:44 ` Kumar Gala
2011-10-18 7:13 ` Wolfgang Grandegger [this message]
2011-10-18 7:13 ` Wolfgang Grandegger
2011-10-18 9:43 ` Robin Holt
2011-10-18 9:43 ` Robin Holt
2011-10-18 11:43 ` Kumar Gala
2011-10-18 11:43 ` Kumar Gala
2011-10-18 11:48 ` Marc Kleine-Budde
2011-10-18 11:48 ` Marc Kleine-Budde
2011-10-18 12:30 ` Robin Holt
2011-10-18 12:30 ` Robin Holt
2011-10-25 21:37 ` Scott Wood
2011-10-25 21:37 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9D2731.4010800@grandegger.com \
--to=wg@grandegger.com \
--cc=B22300@freescale.com \
--cc=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=holt@sgi.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.