From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RG3sD-00019Z-98
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 03:14:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RG3sC-0008Uv-6j
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 03:14:05 -0400
Received: from [222.73.24.84] (port=57378 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RG3s9-0008Tp-US
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 03:14:04 -0400
Message-ID: <4E9D2791.5070207@cn.fujitsu.com>
Date: Tue, 18 Oct 2011 15:15:29 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4E8ECA91.8040409@cn.fujitsu.com> <4E8ED167.1000705@siemens.com>
	<20111008151622.GA17181@amd.home.annexia.org>
	<4E916035.5050906@web.de>
	<20111009102338.GN16799@amd.home.annexia.org>
	<4E92568E.2010507@cn.fujitsu.com> <4E929618.4040403@web.de>
	<20111010090246.GF9408@redhat.com> <4E92BC11.3030508@siemens.com>
In-Reply-To: <4E92BC11.3030508@siemens.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Question] dump memory when host pci device is
 used by guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, "Richard W.M. Jones" <rjones@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Hi, Jan Kiszka

At 10/10/2011 05:34 PM, Jan Kiszka Write:
> On 2011-10-10 11:02, Daniel P. Berrange wrote:
>> On Mon, Oct 10, 2011 at 08:52:08AM +0200, Jan Kiszka wrote:

> 
> Run gdb with "set debug remote 1" and watch the communication, it is not
> that complex. But a dump command is probably simpler for those
> scenarios, I agree.

I have implemented the command dump and reuse migration's code. But I meet a problem
when I test it.

My qemu-kvm's tree is not updated about 2 months ago, because kernel.org is down, and
I forgot to pull from github.

After I pull it from github, I find the following changes:
@@ -1523,9 +1523,7 @@ static void assigned_dev_unregister_msix_mmio(AssignedDevice *dev)
 
 static const VMStateDescription vmstate_assigned_device = {
     .name = "pci-assign",
-    .fields = (VMStateField []) {
-        VMSTATE_END_OF_LIST()
-    }
+    .unmigratable = 1,
 };
 
 static void reset_assigned_device(DeviceState *dev)

Why do you remove fields from vmstate_assigned_device?
It is useful for dump because it does not check unmigratable. If vmstate_assigned_device
does not contain .fields, qemu will crash in vmstate_save_state().

Thanks
Wen Congyang

> 
> Jan
>