From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH 0/1] IMSM do not assume prev + current map in same state means reshape Date: Tue, 18 Oct 2011 09:36:24 +0200 Message-ID: <4E9D2C78.5030709@redhat.com> References: <1318884015-14749-1-git-send-email-Jes.Sorensen@redhat.com> <79556383A0E1384DB3A3903742AAC04A040217@IRSMSX101.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <79556383A0E1384DB3A3903742AAC04A040217@IRSMSX101.ger.corp.intel.com> Sender: linux-raid-owner@vger.kernel.org To: "Kwolek, Adam" Cc: "linux-raid@vger.kernel.org" , "neilb@suse.de" , "dledford@redhat.com" , "Dorau, Lukasz" , "Labun, Marcin" List-Id: linux-raid.ids On 10/18/11 09:09, Kwolek, Adam wrote: > > >> -----Original Message----- >> From: Jes.Sorensen@redhat.com [mailto:Jes.Sorensen@redhat.com] >> I believe there is a bug in the current IMSM code. It makes the assumption >> that if the state of the previous map and the current map are the same, it >> means we are trying to reshape the array. However if you have a large array >> and just installed on it, and it was still resyncing when you rebooted, it will >> come up in the same state and 'mdadm -Aa' will fail with an error that it is >> lacking a resync file. >> >> This is what prevents an update Fedora 15 system from booting, such as >> https://bugzilla.redhat.com/show_bug.cgi?id=736387 >> >> If I am missing something here, I'd appreciate to hear about it. >> >> Thanks, >> Jes > > > Hi, > There is bug there as you pointed in your email, but it is already fixed in Neil's repository by commit : > imsm: fix: stopped resync does not continue after auto-assemblation > b601104eb4a4733a838fb86e9e279fed14ce9d3f > > Your patch "IMSM do not assume prev + current map in same state means reshape" can break > e.g chunk size migration when number of disks doesn't change. > > Correct fix is pointed above and it tests migration type. Interesting, this fix went in just after I started doing my testing so I don't seem to have it in my tree. Missed it by a day or two :( I'll refresh and try it out. Jes