From mboxrd@z Thu Jan  1 00:00:00 1970
From: lauri.hintsala@bluegiga.com (Lauri Hintsala)
Date: Tue, 18 Oct 2011 10:45:30 +0300
Subject: [PATCH] ARM: mxs: Add initial support for Bluegiga
	APX4	Development Kit
In-Reply-To: <20111017103958.GD7761@tarshish>
References: <1318838916-8529-1-git-send-email-lauri.hintsala@bluegiga.com>	<20111017094434.GA21504@pengutronix.de>
	<20111017103958.GD7761@tarshish>
Message-ID: <4E9D2E9A.8000600@bluegiga.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Baruch,

On 10/17/2011 01:39 PM, Baruch Siach wrote:
> Hi Uwe, Lauri,
> On Mon, Oct 17, 2011 at 11:44:34AM +0200, Uwe Kleine-K?nig wrote:
>> Hello,
>>
>> On Mon, Oct 17, 2011 at 11:08:36AM +0300, Lauri Hintsala wrote:
>>> Added initial support for Bluegiga APX4 module and Development Kit.
>>> Patches are based on Linux v3.1-rc9.
>
> [snip]
>
>>> +static int __init apx4devkit_fec_get_mac(char *macstr)
>>> +{
>>> +	int i, h, l;
>>> +
>>> +	macstr++;
>>> +
>>> +	for (i = 0; i<  6; i++) {
>>> +		if (i != 5&&  *(macstr + 2) != ':')
>>> +			goto error;
>>> +
>>> +		h = hex_to_bin(*macstr++);
>>> +		if (h == -1)
>>> +			goto error;
>>> +
>>> +		l = hex_to_bin(*macstr++);
>>> +		if (l == -1)
>>> +			goto error;
>>> +
>>> +		macstr++;
>>> +		mx28_fec_pdata.mac[i] = (h<<  4) + l;
>>> +	}
>>> +	return 0;
>> I wonder if there isn't a more generic way to parse a mac address.
>>
>> Other machines put the mac into the otp.
>>
>>> +error:
>>> +	pr_err("%s: invalid mac address\n", __func__);
>>> +	return -EINVAL;
>>> +}
>>> +
>>> +__setup("ethaddr", apx4devkit_fec_get_mac);
>> the name is IMHO too generic for a board specific parameter. Think about
>> a kernel that runs on all mxs based machines. ethaddr=... only affects
>> your machine type. And it's not possible to add the same parameter to a
>> different board.
>
> The fec driver already supports the macaddr module parameter. See the comment
> at the beginning of the fec_get_mac() routine in drivers/net/fec.c.

We are passing mac address from uboot. Uboot's format is 
"xx:xx:xx:xx:xx:xx" and fec is getting mac address as array 
"0x00,0x04,0x9f,0x01,0x30,0xe0". So using fec's routine is not very 
useful in our case.

Best Regards,
Lauri Hintsala