All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hughes <john@Calva.COM>
To: Mattia Dongili <malattia@linux.it>
Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
	Stelian Pop <stelian@popies.net>,
	platform-driver-x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work
Date: Tue, 18 Oct 2011 11:07:17 +0200	[thread overview]
Message-ID: <4E9D41C5.70902@Calva.COM> (raw)
In-Reply-To: <20111017214543.GB1311@kamineko.org>

On 17/10/11 23:45, Mattia Dongili wrote:
> On Sun, Oct 16, 2011 at 05:50:13PM -0400, Valdis.Kletnieks@vt.edu wrote:
>    
>> On Mon, 17 Oct 2011 06:38:01 +0900, Mattia Dongili said:
>>      
>> If that's not an option, perhaps we need a per-model quirk that patches up the
>> tables at boot time?  If we do that, we may want to re-arrange the table so the
>> affected entries are at the front or something to help insure we don't patch
>> the wrong entries if somebody else inserts new lines.
>>      
> Wouldn't udev do that already?
> We may actually want to remove those events that never get looked up in
> the tables instead.
>
>    
udev does have some per-model stuff for the Vaio's.

Doesn't work right because the scancodes reported the sony-laptop driver 
are not the right ones.

(sony-laptop sends its "event" code as the scancode, but to change the 
keymap you have to use the index in the sony_laptop_input_keycode_map 
table.  I have posted one patch for this which makes the scancodes at 
least consistent but I think I'll do another that makes them be the same 
as what current udev thinks they should be.  I'll have that ready this 
evening I thing - have to work now :-( )

  reply	other threads:[~2011-10-18  9:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-16 11:11 sony-laptop driver: Volume keys on Sony Vaio TX3 don't work John Hughes
2011-10-16 12:30 ` Bug: changing keycodes generated by sony-laptop doesn't work John Hughes
2011-10-16 13:30   ` John Hughes
2011-10-17  9:08     ` John Hughes
2011-10-16 13:27 ` sony-laptop driver: Volume keys on Sony Vaio TX3 don't work John Hughes
2011-10-16 17:45   ` John Hughes
2011-10-16 18:20     ` Valdis.Kletnieks
2011-10-16 21:38       ` Mattia Dongili
2011-10-16 21:50         ` Valdis.Kletnieks
2011-10-16 23:17           ` John Hughes
2011-10-17 21:43             ` Mattia Dongili
2011-10-18  9:02               ` John Hughes
2011-10-17 21:45           ` Mattia Dongili
2011-10-18  9:07             ` John Hughes [this message]
2011-10-19 22:01               ` John Hughes
2011-10-16 23:13       ` John Hughes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9D41C5.70902@Calva.COM \
    --to=john@calva.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.