All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Avoid recursive calls from dmeventd to itself
Date: Tue, 18 Oct 2011 14:56:00 +0200	[thread overview]
Message-ID: <4E9D7760.6050400@redhat.com> (raw)
In-Reply-To: <87y5wsq5l9.fsf@aldalome.int.mornfall.net.>

On 10/10/2011 04:33 PM, Petr Rockai wrote:
> Petr Rockai <prockai@redhat.com> writes:
> 
>>> It might be a little more code, but I'd rather see it a property of the handle
>>> never to perform dmeventd monitoring calls.  We never fixed handle init to 
>>> take multiple settings, so maybe call
>>>   void lvm2_disable_dmeventd_monitoring(void *handle)
>>> after handle initialisation to set DMEVENTD_MONITOR_DISABLED and have that take
>>> precedence over any later attempt to enable monitoring.
>>
>> This sounds like a better option. Now that raises the question why we
>> aren't doing the same thing for memlock_{inc,dec}? We should certainly
>> unify these two things. I'll have a look, and unless I run into a
>> stumbling block will submit a patch to do that.
> 
> The patch doing that is attached. Seems straightforward enough to me. We
> can change the memlock interface to be the same, too.

ack.

Milan



      reply	other threads:[~2011-10-18 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01  1:08 [PATCH] Avoid recursive calls from dmeventd to itself Petr Rockai
2011-09-01 19:42 ` Alasdair G Kergon
2011-09-02 12:50   ` Petr Rockai
2011-10-10 14:33     ` Petr Rockai
2011-10-18 12:56       ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9D7760.6050400@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.