From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Cc: "Roedel, Joerg" <Joerg.Roedel@amd.com>, Gleb Natapov <gleb@redhat.com>
Subject: [PATCH] KVM: SVM: Keep intercepting task switching with NPT enabled
Date: Tue, 18 Oct 2011 18:23:11 +0200 [thread overview]
Message-ID: <4E9DA7EF.30804@siemens.com> (raw)
AMD processors apparently have a bug in the hardware task switching
support when NPT is enabled. If the task switch triggers a NPF, we can
get wrong EXITINTINFO along with that fault. On resume, spurious
exceptions may then be injected into the guest.
We were able to reproduce this bug when our guest triggered #SS and the
handler were supposed to run over a separate task with not yet touched
stack pages.
Work around the issue by continuing to emulate task switches even in
NPT mode.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/x86/kvm/svm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index e7ed4b1..e32243e 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1084,7 +1084,6 @@ static void init_vmcb(struct vcpu_svm *svm)
if (npt_enabled) {
/* Setup VMCB for Nested Paging */
control->nested_ctl = 1;
- clr_intercept(svm, INTERCEPT_TASK_SWITCH);
clr_intercept(svm, INTERCEPT_INVLPG);
clr_exception_intercept(svm, PF_VECTOR);
clr_cr_intercept(svm, INTERCEPT_CR3_READ);
--
1.7.3.4
next reply other threads:[~2011-10-18 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 16:23 Jan Kiszka [this message]
2011-10-18 16:35 ` [PATCH] KVM: SVM: Keep intercepting task switching with NPT enabled Roedel, Joerg
2011-10-18 17:37 ` Avi Kivity
2011-10-19 14:12 ` Roedel, Joerg
2011-11-01 11:13 ` Roedel, Joerg
2011-11-01 13:39 ` Jan Kiszka
2011-11-01 15:30 ` Roedel, Joerg
2011-11-01 15:49 ` Jan Kiszka
2011-11-01 16:15 ` Roedel, Joerg
2011-11-01 18:22 ` Jan Kiszka
2011-11-02 9:55 ` Roedel, Joerg
2011-11-02 9:59 ` Jan Kiszka
2011-11-02 10:04 ` Avi Kivity
2011-10-27 12:40 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9DA7EF.30804@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Joerg.Roedel@amd.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.