All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, doc: add CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST documentation
Date: Wed, 19 Oct 2011 07:48:53 +0200	[thread overview]
Message-ID: <4E9E64C5.50800@denx.de> (raw)
In-Reply-To: <CA+M6bX=5ky833jJYi19OZMnWS0oQr-85aBsB5DZhrxc8ECTRAA@mail.gmail.com>

Hello Tom,

added Sandeep Paulraj to cc, as he is the ti custodian ...

Tom Rini wrote:
> Ah, but we asked (and you agreed) to name the option generically since

Where do you read, that I agreed to rename this config option?

I just wrote:

http://lists.denx.de/pipermail/u-boot/2011-October/104784.html

"Ok, you are right, there is no documentation of this config option.
Should I add this documentation in this patch or in a seperate patch?"

and Wolfgang Denk said here:

http://lists.denx.de/pipermail/u-boot/2011-October/104786.html

"Separate, please.  Thanks."

...

> it's about OOB position rather than ECC size.  And the help should
> reflect that it's about changing the OOB position relative to data as
> foudn on some davinci platforms rather than just being to enable
> support in davinci SoCs.  Other boards might need this :)

Maybe I oversee something, but as I see in Code, this feature is
davinci only (as this is a CPU feature) ... Ah, maybe I got it!

I added this option to "drivers/mtd/nand/nand_spl_simple.c" and there
it should get a more common name, right? ...

Ok, so I see the following to do:

rework patch:
http://lists.denx.de/pipermail/u-boot/2011-October/104769.html

- rename "CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST" to
  "CONFIG_SYS_NAND_ECC_OOBFIRST"?
- add a doc for this new config option
- add this new config option to the enbw_cmc board support

This doc patch:
http://lists.denx.de/pipermail/u-boot/2011-October/104907.html

- This can go to mainline, as it just documents the existing
  CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST config option for davinci
  socs.

Ok?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2011-10-19  5:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  5:34 [U-Boot] [PATCH] arm, doc: add CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST documentation Heiko Schocher
2011-10-18 16:01 ` Tom Rini
2011-10-19  5:48   ` Heiko Schocher [this message]
2011-10-19  6:07     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9E64C5.50800@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.