Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch

[Jonathan Cameron <jic23@cam.ac.uk>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On 10/19/11 02:27, David Rientjes wrote:
> On Tue, 18 Oct 2011, Joe Perches wrote:
> 
>>>> This started happening when I run checkpatch on pretty much anything.
>>>> triggered by the b in this snipped for example
>>>> diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
>>>> index 3f8d0af..62dc2a8 100644
>>>> --- a/arch/arm/mach-pxa/stargate2.c
>>>> +++ b/arch/arm/mach-pxa/stargate2.c
>>>> @@ -54,6 +54,8 @@
>>>>  #include <linux/mfd/da903x.h>
>>>> Anyone else seeing this or have a clue what the heck is going on?
>>
>> It's done this since:
>>
>> $ git log -1 1e85572697b348b1a126520349a29654f2ae6a12
>> commit 1e85572697b348b1a126520349a29654f2ae6a12
>> Author: Wolfram Sang <w.sang@pengutronix.de>
>> Date:   Tue Jan 6 14:41:24 2009 -0800
>>
>>     checkpatch: Add warning for p0-patches
>>     
> 
> Hmm, not sure how useful that is unless both prefixes ('a' and 'b') exist.
Sorry, I missed one detail. This warning is firing on every patch including
any I pull off mailing lists or produce with git format-patch

As you can imagine - this is rather tedious.

As a random example see the attached patch from yesterday.

Jonathan

[-- Attachment #2: [PATCHv3 6_7] input_cma3000_d0x: Unwind reverse order of init.eml --]
[-- Type: message/rfc822, Size: 3552 bytes --]

From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: dmitry.torokhov@gmail.com, sameo@linux.intel.com, peter.ujfalusi@ti.com, aghayal@codeaurora.org, david@hardeman.nu, Shubhrajyoti@ti.com, saaguirre@ti.com, jic23@cam.ac.uk, hemanthv@ti.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init
Date: Tue, 18 Oct 2011 17:48:05 +0200
Message-ID: <1318952886-835-7-git-send-email-ricardo.ribalda@gmail.com>


Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/input/misc/cma3000_d0x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
index bbda34c..96a46d4 100644
--- a/drivers/input/misc/cma3000_d0x.c
+++ b/drivers/input/misc/cma3000_d0x.c
@@ -459,8 +459,8 @@ EXPORT_SYMBOL(cma3000_init);
 
 void cma3000_exit(struct cma3000_accl_data *data)
 {
-	free_irq(data->irq, data);
 	input_unregister_device(data->input_dev);
+	free_irq(data->irq, data);
 	kfree(data);
 }
 EXPORT_SYMBOL(cma3000_exit);
-- 
1.7.7