All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	linux-iio@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH 3/4] staging:iio:dac:ad5791: Convert attributes to new naming spec
Date: Wed, 19 Oct 2011 14:02:30 +0100	[thread overview]
Message-ID: <4E9ECA66.7040607@cam.ac.uk> (raw)
In-Reply-To: <1319027030-9696-3-git-send-email-lars@metafoo.de>

On 10/19/11 13:23, Lars-Peter Clausen wrote:
> Add the missing "voltage" chan_type to the powerdown attributes.
Dratt. I thought I'd fixed all these. Guess I forgot the
output devices.  Good catch
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  drivers/staging/iio/dac/ad5791.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
> index c465fcf..9ba45f1 100644
> --- a/drivers/staging/iio/dac/ad5791.c
> +++ b/drivers/staging/iio/dac/ad5791.c
> @@ -158,24 +158,24 @@ static ssize_t ad5791_write_dac_powerdown(struct device *dev,
>  	return ret ? ret : len;
>  }
>  
> -static IIO_DEVICE_ATTR(out_powerdown_mode, S_IRUGO |
> +static IIO_DEVICE_ATTR(out_voltage_powerdown_mode, S_IRUGO |
>  			S_IWUSR, ad5791_read_powerdown_mode,
>  			ad5791_write_powerdown_mode, 0);
>  
> -static IIO_CONST_ATTR(out_powerdown_mode_available,
> +static IIO_CONST_ATTR(out_voltage_powerdown_mode_available,
>  			"6kohm_to_gnd three_state");
>  
>  #define IIO_DEV_ATTR_DAC_POWERDOWN(_num, _show, _store, _addr)		\
> -	IIO_DEVICE_ATTR(out##_num##_powerdown,				\
> +	IIO_DEVICE_ATTR(out_voltage##_num##_powerdown,			\
>  			S_IRUGO | S_IWUSR, _show, _store, _addr)
>  
>  static IIO_DEV_ATTR_DAC_POWERDOWN(0, ad5791_read_dac_powerdown,
>  				   ad5791_write_dac_powerdown, 0);
>  
>  static struct attribute *ad5791_attributes[] = {
> -	&iio_dev_attr_out0_powerdown.dev_attr.attr,
> -	&iio_dev_attr_out_powerdown_mode.dev_attr.attr,
> -	&iio_const_attr_out_powerdown_mode_available.dev_attr.attr,
> +	&iio_dev_attr_out_voltage0_powerdown.dev_attr.attr,
> +	&iio_dev_attr_out_voltage_powerdown_mode.dev_attr.attr,
> +	&iio_const_attr_out_voltage_powerdown_mode_available.dev_attr.attr,
>  	NULL,
>  };
>  


  reply	other threads:[~2011-10-19 13:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 12:23 [PATCH 1/4] staging:iio:dac:ad5791: Use correct DAC bit-size Lars-Peter Clausen
2011-10-19 12:23 ` [PATCH 2/4] staging:iio:dac:ad5791: Allow asymmetrical reference voltages Lars-Peter Clausen
2011-10-19 13:01   ` Jonathan Cameron
2011-10-19 13:21     ` Lars-Peter Clausen
2011-10-19 13:39       ` Jonathan Cameron
2011-10-19 12:23 ` [PATCH 3/4] staging:iio:dac:ad5791: Convert attributes to new naming spec Lars-Peter Clausen
2011-10-19 13:02   ` Jonathan Cameron [this message]
2011-10-19 12:23 ` [PATCH 4/4] staging:iio:dac:ad5791: Fix scale unit Lars-Peter Clausen
2011-10-19 13:03   ` Jonathan Cameron
2011-10-19 12:57 ` [PATCH 1/4] staging:iio:dac:ad5791: Use correct DAC bit-size Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2011-10-19 15:47 Lars-Peter Clausen
2011-10-19 15:47 ` [PATCH 3/4] staging:iio:dac:ad5791: Convert attributes to new naming spec Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9ECA66.7040607@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.