From: Clemens Ladisch <clemens@ladisch.de>
To: Joe Perches <joe@perches.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: firewire: Neaten cmp_error function
Date: Thu, 20 Oct 2011 08:36:55 +0200 [thread overview]
Message-ID: <4E9FC187.4060309@ladisch.de> (raw)
In-Reply-To: <1319086869.28078.6.camel@Joe-Laptop>
Joe Perches wrote:
> Use an actual struct va_format instead of casting
> an array of pointers.
> - dev_err(&c->resources.unit->device, "%cPCR%u: %pV",
> - 'i', c->pcr_index, &(struct va_format){ fmt, &va });
There is no cast. This compound literal _is_ an actual
struct va_format.
> Move a constant char argument to the format string.
Good catch, but this module is going to be extended to handle
oPCRs, too.
Regards,
Clemens
parent reply other threads:[~2011-10-20 6:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1319086869.28078.6.camel@Joe-Laptop>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9FC187.4060309@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.