* Re: [PATCH] ALSA: firewire: Neaten cmp_error function
[not found] <1319086869.28078.6.camel@Joe-Laptop>
@ 2011-10-20 6:36 ` Clemens Ladisch
0 siblings, 0 replies; only message in thread
From: Clemens Ladisch @ 2011-10-20 6:36 UTC (permalink / raw)
To: Joe Perches; +Cc: Takashi Iwai, alsa-devel
Joe Perches wrote:
> Use an actual struct va_format instead of casting
> an array of pointers.
> - dev_err(&c->resources.unit->device, "%cPCR%u: %pV",
> - 'i', c->pcr_index, &(struct va_format){ fmt, &va });
There is no cast. This compound literal _is_ an actual
struct va_format.
> Move a constant char argument to the format string.
Good catch, but this module is going to be extended to handle
oPCRs, too.
Regards,
Clemens
^ permalink raw reply [flat|nested] only message in thread