From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>, sdb@zubnet.me.uk
Subject: Re: [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()
Date: Thu, 20 Oct 2011 10:55:38 +0200 [thread overview]
Message-ID: <4E9FE20A.5020000@redhat.com> (raw)
In-Reply-To: <1319097820-4788-1-git-send-email-sdb@zubnet.me.uk>
On 10/20/2011 10:03 AM, Stuart Brady wrote:
> Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0()
> respectively, in cases where the return value is casted to the same
> type as specified using sizeof() in the parameter to g_malloc() and
> assigned to a variable of that type.
This is likely to cause conflicts all over the place, and now is a very
bad time to do so :( because people are trying to get their patches in
during the soft feature freeze. I don't oppose the change, just the timing.
Paolo
next prev parent reply other threads:[~2011-10-20 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 8:03 [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new() Stuart Brady
2011-10-20 8:03 ` [Qemu-devel] [PATCH 2/5] Convert use of ptr = g_malloc(sizeof(*ptr)) " Stuart Brady
2011-10-20 8:03 ` [Qemu-devel] [PATCH 3/5] Convert use of ptr = g_malloc(sizeof(type)) " Stuart Brady
2011-10-20 8:03 ` [Qemu-devel] [PATCH 4/5] Convert remaining calls to g_malloc(sizeof(type)) using casts " Stuart Brady
2011-10-20 8:03 ` [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) " Stuart Brady
2011-10-20 9:05 ` Paolo Bonzini
2011-10-21 0:26 ` Stuart Brady
2011-10-21 7:37 ` Paolo Bonzini
2011-10-21 17:56 ` Stuart Brady
2011-10-23 13:45 ` Blue Swirl
2011-10-20 8:55 ` Paolo Bonzini [this message]
2011-10-21 0:34 ` [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts " Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9FE20A.5020000@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sdb@zubnet.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.