Re: [Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/20/2011 11:14 AM, Kevin Wolf wrote:
>> >  diff --git a/block/vpc.c b/block/vpc.c
>> >  index cb6c570..549a632 100644
>> >  --- a/block/vpc.c
>> >  +++ b/block/vpc.c
>> >  @@ -463,6 +463,14 @@ static int calculate_geometry(int64_t total_sectors, uint16_t* cyls,
>> >    {
>> >        uint32_t cyls_times_heads;
>> >
>> >  +    if (total_sectors<= 5760) {
>> >  +        /* Floppy disk geometry */
> Please state in the comment that this part is deviating from the
> algorithm in the VHD spec, which this function is generally supposed to
> implement.

Hmm, looks like virtual PC uses a separate "VFD" image for floppies, so 
I can drop this.

Paolo