diff for duplicates of <4EA02818.9000206@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 83ce1f8..f728dea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -34,11 +34,11 @@ You really should push this part into queue processing on the device. > From 48472bae269b7b1a4047967ec21eadb217c4fd6d Mon Sep 17 00:00:00 2001 - > From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> + > From: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Date: Thu, 20 Oct 2011 15:02:36 +0400 > Subject: [PATCH] 6LoWPAN fragmentation support > - > Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> + > Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > net/ieee802154/6lowpan.c | 286 +++++++++++++++++++++++++++++++++++++++++++++- @@ -261,7 +261,7 @@ tag); > + > + mutex_lock(&flist_lock); > + list_for_each_entry_safe(entry, tmp, &lowpan_fragments, list) - > + if (entry->tag = tag) { + > + if (entry->tag == tag) { > + list_del(&entry->list); > + kfree(entry->data); > + kfree(entry); @@ -304,7 +304,7 @@ time out wipe. > + */ > + rcu_read_lock(); > + list_for_each_entry_rcu(entry, &lowpan_fragments, list) - > + if (entry->tag = tag) { + > + if (entry->tag == tag) { > + pr_debug("%s ERROR: frame with this tag is" > + "alredy in assembling", __func__); > + goto drop_rcu; @@ -369,7 +369,7 @@ BTW: Did you study the skb reassembly code of IPv4? > + > + rcu_read_lock(); > + list_for_each_entry_rcu(entry, &lowpan_fragments, list) - > + if (entry->tag = tag) + > + if (entry->tag == tag) > + break; > + rcu_read_unlock(); > + @@ -400,7 +400,7 @@ can not! > + __func__, entry->length, entry->bytes_rcv); > + > + /* frame assembling complete */ - > + if (entry->bytes_rcv = entry->length) { + > + if (entry->bytes_rcv == entry->length) { > + struct sk_buff *tmp = skb; @@ -409,7 +409,7 @@ WTF? > + > + mutex_lock(&flist_lock); > + list_for_each_entry_safe(entry, t, &lowpan_fragments, list) - > + if (entry->tag = tag) { + > + if (entry->tag == tag) { > + list_del(&entry->list); > + /* copy and clear skb */ > + skb = skb_copy_expand(skb, entry->length, @@ -456,7 +456,7 @@ struct net_device *dev, > goto drop; > > /* check that it's our buffer */ - > - if ((skb->data[0] & 0xe0) = 0x60) + > - if ((skb->data[0] & 0xe0) == 0x60) > + switch (skb->data[0] & 0xe0) { > + case 0x60: /* ipv6 datagram */ > + case 0xc0: /* first fragment header */ @@ -496,3 +496,10 @@ Is it a standard defined interval? -- With best wishes Dmitry + +------------------------------------------------------------------------------ +The demand for IT networking professionals continues to grow, and the +demand for specialized networking skills is growing even more rapidly. +Take a complimentary Learning@Ciosco Self-Assessment and learn +about Cisco certifications, training, and career opportunities. +http://p.sf.net/sfu/cisco-dev2dev diff --git a/a/content_digest b/N1/content_digest index c5b775e..4e53040 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020111020111718.GA32181@avtobot.ww600.siemens.net\0" "ref\020111020111718.GA32181-AUGNqIMGY+aR2kOLt6zJ8ErlnG4Plg33XqFh9Ls21Oc@public.gmane.org\0" - "From\0Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>\0" + "From\0Dmitry Eremin-Solenikov <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Subject\0Re: [IEEE802.15.4][6LoWPAN] draft for fragmentation support\0" - "Date\0Thu, 20 Oct 2011 13:54:32 +0000\0" + "Date\0Thu, 20 Oct 2011 17:54:32 +0400\0" "To\0Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Cc\0eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org @@ -47,11 +47,11 @@ "\n" "\n" " > From 48472bae269b7b1a4047967ec21eadb217c4fd6d Mon Sep 17 00:00:00 2001\n" - " > From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>\n" + " > From: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" " > Date: Thu, 20 Oct 2011 15:02:36 +0400\n" " > Subject: [PATCH] 6LoWPAN fragmentation support\n" " >\n" - " > Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>\n" + " > Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" " > ---\n" " > net/ieee802154/6lowpan.c | 286 \n" "+++++++++++++++++++++++++++++++++++++++++++++-\n" @@ -274,7 +274,7 @@ " > +\n" " > + mutex_lock(&flist_lock);\n" " > + list_for_each_entry_safe(entry, tmp, &lowpan_fragments, list)\n" - " > + if (entry->tag = tag) {\n" + " > + if (entry->tag == tag) {\n" " > + list_del(&entry->list);\n" " > + kfree(entry->data);\n" " > + kfree(entry);\n" @@ -317,7 +317,7 @@ " > + */\n" " > + rcu_read_lock();\n" " > + list_for_each_entry_rcu(entry, &lowpan_fragments, list)\n" - " > + if (entry->tag = tag) {\n" + " > + if (entry->tag == tag) {\n" " > + pr_debug(\"%s ERROR: frame with this tag is\"\n" " > + \"alredy in assembling\", __func__);\n" " > + goto drop_rcu;\n" @@ -382,7 +382,7 @@ " > +\n" " > + rcu_read_lock();\n" " > + list_for_each_entry_rcu(entry, &lowpan_fragments, list)\n" - " > + if (entry->tag = tag)\n" + " > + if (entry->tag == tag)\n" " > + break;\n" " > + rcu_read_unlock();\n" " > +\n" @@ -413,7 +413,7 @@ " > + __func__, entry->length, entry->bytes_rcv);\n" " > +\n" " > + /* frame assembling complete */\n" - " > + if (entry->bytes_rcv = entry->length) {\n" + " > + if (entry->bytes_rcv == entry->length) {\n" " > + struct sk_buff *tmp = skb;\n" "\n" "\n" @@ -422,7 +422,7 @@ " > +\n" " > + mutex_lock(&flist_lock);\n" " > + list_for_each_entry_safe(entry, t, &lowpan_fragments, list)\n" - " > + if (entry->tag = tag) {\n" + " > + if (entry->tag == tag) {\n" " > + list_del(&entry->list);\n" " > + /* copy and clear skb */\n" " > + skb = skb_copy_expand(skb, entry->length, \n" @@ -469,7 +469,7 @@ " > goto drop;\n" " >\n" " > /* check that it's our buffer */\n" - " > - if ((skb->data[0] & 0xe0) = 0x60)\n" + " > - if ((skb->data[0] & 0xe0) == 0x60)\n" " > + switch (skb->data[0] & 0xe0) {\n" " > + case 0x60: /* ipv6 datagram */\n" " > + case 0xc0: /* first fragment header */\n" @@ -508,6 +508,13 @@ "\n" "-- \n" "With best wishes\n" - Dmitry + "Dmitry\n" + "\n" + "------------------------------------------------------------------------------\n" + "The demand for IT networking professionals continues to grow, and the\n" + "demand for specialized networking skills is growing even more rapidly.\n" + "Take a complimentary Learning@Ciosco Self-Assessment and learn \n" + "about Cisco certifications, training, and career opportunities. \n" + http://p.sf.net/sfu/cisco-dev2dev -4adb825408e75006aa0d215a90ab8b76e8551e71274380a64d656e3027bca9e2 +1950ceca0fe3f47a36a0c52b657b7db8afa4a49c5b3d10765a21c3c4f7d57e74
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.