From: Jeff Garzik <jeff@garzik.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Florian Tobias Schandinat" <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org,
"Christian T. Steigies" <cts@debian.org>,
linux-kernel@vger.kernel.org,
"Ingo Jürgensmann" <ij@2011.bluespice.org>
Subject: Re: [PATCH 2/4] fbdev/cirrusfb: Rewrite Zorro graphics card probing
Date: Thu, 20 Oct 2011 17:03:09 +0000 [thread overview]
Message-ID: <4EA0544D.3070705@garzik.org> (raw)
In-Reply-To: <1319110945-25684-2-git-send-email-geert@linux-m68k.org>
On 10/20/2011 07:42 AM, Geert Uytterhoeven wrote:
> As indicated by commit a7f4d00a82feb5b311f765bf9522bc55bee0684f ("zorro:
> Defer device_register() until all devices have been identified"), cirrusfb
> crashes if zorro_find_device() cannot find an expected device.
>
> Rewrite the Zorro device probe code to make it more robust, easier to
> understand, and more extensible.
>
> Other logical changes:
> - For cards that show up as 2 Zorro devices, autoprobe graphics memory
> sizes based on the size of the Zorro device containing the graphics
> memory.
> Acording to the NetBSD sources, this is safe.
>
> Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Florian Tobias Schandinat" <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org,
"Christian T. Steigies" <cts@debian.org>,
linux-kernel@vger.kernel.org,
"Ingo Jürgensmann" <ij@2011.bluespice.org>
Subject: Re: [PATCH 2/4] fbdev/cirrusfb: Rewrite Zorro graphics card probing
Date: Thu, 20 Oct 2011 13:03:09 -0400 [thread overview]
Message-ID: <4EA0544D.3070705@garzik.org> (raw)
In-Reply-To: <1319110945-25684-2-git-send-email-geert@linux-m68k.org>
On 10/20/2011 07:42 AM, Geert Uytterhoeven wrote:
> As indicated by commit a7f4d00a82feb5b311f765bf9522bc55bee0684f ("zorro:
> Defer device_register() until all devices have been identified"), cirrusfb
> crashes if zorro_find_device() cannot find an expected device.
>
> Rewrite the Zorro device probe code to make it more robust, easier to
> understand, and more extensible.
>
> Other logical changes:
> - For cards that show up as 2 Zorro devices, autoprobe graphics memory
> sizes based on the size of the Zorro device containing the graphics
> memory.
> Acording to the NetBSD sources, this is safe.
>
> Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
next prev parent reply other threads:[~2011-10-20 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 11:42 [PATCH 1/4] zorro: Rename Picasso IV Z2 "MEM" to "RAM" for consistency Geert Uytterhoeven
2011-10-20 11:42 ` Geert Uytterhoeven
2011-10-20 11:42 ` [PATCH 2/4] fbdev/cirrusfb: Rewrite Zorro graphics card probing Geert Uytterhoeven
2011-10-20 11:42 ` Geert Uytterhoeven
2011-10-20 17:03 ` Jeff Garzik [this message]
2011-10-20 17:03 ` Jeff Garzik
2011-10-20 11:42 ` [PATCH 3/4] fbdev/cirrusfb: Add support for Picasso IV in Zorro II mode Geert Uytterhoeven
2011-10-20 11:42 ` Geert Uytterhoeven
2011-10-20 17:03 ` [PATCH 3/4] fbdev/cirrusfb: Add support for Picasso IV in Zorro Jeff Garzik
2011-10-20 17:03 ` [PATCH 3/4] fbdev/cirrusfb: Add support for Picasso IV in Zorro II mode Jeff Garzik
2011-10-20 11:42 ` [PATCH 4/4] fbdev/cirrusfb: Add support for "64 MiB" version of Picasso IV Geert Uytterhoeven
2011-10-20 11:42 ` Geert Uytterhoeven
2011-10-20 17:03 ` [PATCH 4/4] fbdev/cirrusfb: Add support for "64 MiB" version Jeff Garzik
2011-10-20 17:03 ` [PATCH 4/4] fbdev/cirrusfb: Add support for "64 MiB" version of Picasso IV Jeff Garzik
2011-11-12 0:20 ` [PATCH 1/4] zorro: Rename Picasso IV Z2 "MEM" to "RAM" for consistency Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA0544D.3070705@garzik.org \
--to=jeff@garzik.org \
--cc=FlorianSchandinat@gmx.de \
--cc=cts@debian.org \
--cc=geert@linux-m68k.org \
--cc=ij@2011.bluespice.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.