Hi Mikel,

On 10/20/2011 11:38 AM, Mikel Astiz wrote:
> The use of g_idle_add can cause a segmentation fault if the object is
> destroyed in the meantime.
> ---
>  drivers/hfpmodem/network-registration.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 

Looks good to me, but please...

> diff --git a/drivers/hfpmodem/network-registration.c b/drivers/hfpmodem/network-registration.c
> index da7d8eb..6c27a23 100644
> --- a/drivers/hfpmodem/network-registration.c
> +++ b/drivers/hfpmodem/network-registration.c
> @@ -51,6 +51,7 @@ struct netreg_data {
>  	GAtChat *chat;
>  	unsigned char cind_pos[HFP_INDICATOR_LAST];
>  	int cind_val[HFP_INDICATOR_LAST];
> +	guint registration_event_id;

...name this 'register_source' to be more consistent with how oFono
names variables that store GSource ids.

Same comment applies to patch 11 and 12.

Regards,
-Denis