From: Jens Axboe <axboe@kernel.dk>
To: David Vrabel <david.vrabel@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] block: initialize the bounce pool if high memory may be added later
Date: Thu, 20 Oct 2011 21:21:49 +0200 [thread overview]
Message-ID: <4EA074CD.9000903@kernel.dk> (raw)
In-Reply-To: <4EA03DDC.9070808@citrix.com>
On 2011-10-20 17:27, David Vrabel wrote:
> On 11/10/11 12:53, David Vrabel wrote:
>> init_emergency_pool() does not create the page pool for bouncing block
>> requests if the current count of high pages is zero. If high memory
>> may be added later (either via memory hotplug or a balloon driver in a
>> virtualized system) then a oops occurs if a request with a high page
>> need bouncing because the pool does not exist.
>>
>> So, always create the pool if memory hotplug is enabled and change the
>> test so it's valid even if all high pages are currently in the balloon
>> (the balloon drivers adjust totalhigh_pages but not max_pfn).
>
> Jens, you don't seem to have picked up this patch yet. Should it have
> gone via Andrew Morton instead?
Added now for 3.2.
--
Jens Axboe
prev parent reply other threads:[~2011-10-20 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 11:53 [PATCH] block: initialize the bounce pool if high memory may be added later David Vrabel
2011-10-20 15:27 ` David Vrabel
2011-10-20 19:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA074CD.9000903@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.