From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RGylG-0003XR-Rg
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:58:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RGylF-0001Gc-KR
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:58:42 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:39026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RGylF-0001GY-2Q
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:58:41 -0400
Message-ID: <4EA07D47.60205@weilnetz.de>
Date: Thu, 20 Oct 2011 21:57:59 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319140085-3431-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1319140085-3431-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by
 wrong trace events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Am 20.10.2011 21:48, schrieb Stefan Weil:
> Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events
> with mismatching format string and arguments.
>
> gcc reports these errors:
>
> In file included from trace.c:2:0:
> trace.h: In function =E2=80=98trace_v9fs_attach=E2=80=99:
> trace.h:2850:9: error: too many arguments for format [-Werror=3Dformat-=
extra-args]
> trace.h: In function =E2=80=98trace_v9fs_wstat=E2=80=99:
> trace.h:3039:9: error: too many arguments for format [-Werror=3Dformat-=
extra-args]
> trace.h: In function =E2=80=98trace_v9fs_mkdir=E2=80=99:
> trace.h:3088:9: error: too many arguments for format [-Werror=3Dformat-=
extra-args]
> trace.h: In function =E2=80=98trace_v9fs_mkdir_return=E2=80=99:
> trace.h:3095:9: error: too many arguments for format [-Werror=3Dformat-=
extra-args]
>
> Fix the format strings and also use %u instead of %d for unsigned value=
s
> in the changed strings. There are more minor errors of this kind
> which I did not fix because that would make the review more difficult.
>
> Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  trace-events |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index fc13733..bd9c5de 100644
> --- a/trace-events
> +++ b/trace-events
...
> +v9fs_mkdir_return(uint16_t tag, uint8_t id, int8_t type, int32_t versi=
on, int64_t path, int err) "tag %u id %u qid=3D{type %d version %d path %=
"PRId64" err %d}"
>

The position of } was wrong here. Please ignore this patch, I'll send a
new one.

- Stefan W.