Re: [PATCH v3 03/15] include: Voice recognition in handsfree public api

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Hi Mikel,

On 10/20/2011 11:38 AM, Mikel Astiz wrote:
> ---
>  include/handsfree.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 

OK, nitpicking time ;)

> diff --git a/include/handsfree.h b/include/handsfree.h
> index a4aa177..4ffd673 100644
> --- a/include/handsfree.h
> +++ b/include/handsfree.h
> @@ -31,6 +31,8 @@ extern "C" {
>  
>  struct ofono_handsfree;
>  
> +typedef void (*ofono_handsfree_cb_t)(const struct ofono_error *error,
> +					void *data);
>  typedef void (*ofono_handsfree_phone_cb_t)(const struct ofono_error *error,
>  					const struct ofono_phone_number *number,
>  					void *data);
> @@ -43,10 +45,15 @@ struct ofono_handsfree_driver {
>  	void (*request_phone_number) (struct ofono_handsfree *hf,
>  					ofono_handsfree_phone_cb_t cb,
>  					void *data);
> +	void (*voice_recognition)(struct ofono_handsfree *cv,

And this should be *hf not *cv.

> +					ofono_bool_t enabled,
> +					ofono_handsfree_cb_t cb, void *data);
>  };
>  
>  void ofono_handsfree_set_inband_ringing(struct ofono_handsfree *hf,
>  						ofono_bool_t enabled);
> +void ofono_handsfree_set_voice_recognition(struct ofono_handsfree *hf,
> +						ofono_bool_t enabled);

Please rename this to ofono_handsfree_voice_recognition_notify.

>  
>  int ofono_handsfree_driver_register(const struct ofono_handsfree_driver *d);
>  void ofono_handsfree_driver_unregister(

Regards,
-Denis