From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RH8DR-0001kR-SO
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 02:04:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RH8DQ-0007jj-V1
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 02:04:25 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:54966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RH8DQ-0007jJ-Kg
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 02:04:24 -0400
Message-ID: <4EA10B35.4080802@weilnetz.de>
Date: Fri, 21 Oct 2011 08:03:33 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1319145085-10561-1-git-send-email-sw@weilnetz.de>	<1319145085-10561-5-git-send-email-sw@weilnetz.de>
	<alpine.LNX.2.00.1110210133160.5076@linmac>
In-Reply-To: <alpine.LNX.2.00.1110210133160.5076@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

Am 20.10.2011 23:36, schrieb malc:
> On Thu, 20 Oct 2011, Stefan Weil wrote:
>
> [..snip..]
>
>> +/* Trace message to see program flow. */
>> +#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
>> +#define TRACE() \
>> +    loglevel \
>> +    ? fprintf(stderr, "TCG %s:%u: %s()\n", __FILE__, __LINE__, __func__) \
>> +    : (void)0
> This is wrong, fprintf's return value is int and not void. Similar issue
> was present today on comp.std.c
> http://groups.google.com/group/comp.std.c/browse_thread/thread/4e01fece59a80572#
>
> [..snip..]

You are right, but it does not matter. TRACE() is never used in
assignments, and gcc accepts the statement as it is.

Nevertheless, I' ll fix it in the next release.

Thanks,
Stefan