All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rajnoha <prajnoha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Add configure option to select default run directory base and prepare for early /run use
Date: Fri, 21 Oct 2011 13:14:23 +0200	[thread overview]
Message-ID: <4EA1540F.6060802@redhat.com> (raw)
In-Reply-To: <4EA14FA2.9030705@redhat.com>

On 10/21/2011 12:55 PM, Zdenek Kabelac wrote:
> Dne 21.10.2011 11:50, Peter Rajnoha napsal(a):
>>  AH_TEMPLATE(DEFAULT_RUN_DIR, [Name of default run directory.])
>>  AC_ARG_WITH(default-run-dir,
>> -	    [  --with-default-run-dir=DIR       Default run directory [[/var/run/lvm]] ],
>> +	    [  --with-default-run-dir=DIR       Default run directory [[RDIR/lvm]] ],
>>  	    [ DEFAULT_RUN_DIR="$withval" ],
>> -	    [ DEFAULT_RUN_DIR="/var/run/lvm" ])
>> +	    [ DEFAULT_RUN_DIR="$DEFAULT_RUN_DIR_BASE/lvm" ])
>>  AC_DEFINE_UNQUOTED(DEFAULT_RUN_DIR,["$DEFAULT_RUN_DIR"] )
>>  
> 
> 
> I guess we should stay with just one place to configure /var/run
> 
> So I'd replace DEFAULT_RUN_DIR usage in the code  with  DEFAULT_RUN_DIR/lvm
> and use just this define.

That's an option as well. Depends on whether we're OK with redefining it this
way... but yes, I'd say it can't do any harm.

Peter



      reply	other threads:[~2011-10-21 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  9:50 [PATCH] Add configure option to select default run directory base and prepare for early /run use Peter Rajnoha
2011-10-21 10:55 ` Zdenek Kabelac
2011-10-21 11:14   ` Peter Rajnoha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA1540F.6060802@redhat.com \
    --to=prajnoha@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.