All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	linux-iio@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH 2/2] staging:iio: Use userspace types for iio_event_data
Date: Fri, 21 Oct 2011 12:39:53 +0100	[thread overview]
Message-ID: <4EA15A09.3050109@cam.ac.uk> (raw)
In-Reply-To: <1319194778-7153-2-git-send-email-lars@metafoo.de>

On 10/21/11 11:59, Lars-Peter Clausen wrote:
> Since we want to export struct iio_event_data to userspace use the userspace
> integer types. Also add a include to linux/types.h.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>

Will add to the series doing reorganization.

Thanks,
> ---
> Followup to "staging:iio: header reorganization". Based on linux-iio/master
> ---
>  drivers/staging/iio/events.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/events.h b/drivers/staging/iio/events.h
> index fbc198e..d1f946e 100644
> --- a/drivers/staging/iio/events.h
> +++ b/drivers/staging/iio/events.h
> @@ -12,6 +12,7 @@
>  #define _IIO_EVENTS_H_
>  
>  #include <linux/ioctl.h>
> +#include <linux/types.h>
>  
>  /**
>   * struct iio_event_data - The actual event being pushed to userspace
> @@ -20,8 +21,8 @@
>   *		the interrupt handler)
>   */
>  struct iio_event_data {
> -	u64	id;
> -	s64	timestamp;
> +	__u64	id;
> +	__s64	timestamp;
>  };
>  
>  #define IIO_GET_EVENT_FD_IOCTL _IOR('i', 0x90, int)


  reply	other threads:[~2011-10-21 11:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  7:21 Userspace event handling and header files Lars-Peter Clausen
2011-10-21  8:02 ` Hennerich, Michael
2011-10-21  8:58   ` Jonathan Cameron
2011-10-21  9:09     ` [PATCH] staging:iio: header reorganization Jonathan Cameron
2011-10-21  9:12       ` Jonathan Cameron
2011-10-21  9:28         ` Jonathan Cameron
2011-10-21 10:42       ` Lars-Peter Clausen
2011-10-21 10:59         ` Jonathan Cameron
2011-10-21 11:15           ` Jonathan Cameron
2011-10-21 10:59         ` [PATCH 1/2] staging:iio: Add missing ioctl.h include to events.h Lars-Peter Clausen
2011-10-21 10:59           ` [PATCH 2/2] staging:iio: Use userspace types for iio_event_data Lars-Peter Clausen
2011-10-21 11:39             ` Jonathan Cameron [this message]
2011-10-21 11:00           ` [PATCH 1/2] staging:iio: Add missing ioctl.h include to events.h Jonathan Cameron
2011-10-21  9:42     ` Userspace event handling and header files Lars-Peter Clausen
2011-10-21  9:44       ` Jonathan Cameron
2011-10-21  9:51         ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2011-10-21 11:49 [V2 PATCH 0/2] staging:iio: header reorganization Jonathan Cameron
2011-10-21 11:49 ` [PATCH 2/2] staging:iio: Use userspace types for iio_event_data Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA15A09.3050109@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.