From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ppsw-51.csi.cam.ac.uk ([131.111.8.151]:40220 "EHLO ppsw-51.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595Ab1JUNIG (ORCPT ); Fri, 21 Oct 2011 09:08:06 -0400 Message-ID: <4EA16EBB.7010800@cam.ac.uk> Date: Fri, 21 Oct 2011 14:08:11 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: Michael Hennerich , linux-iio@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org, drivers@analog.com Subject: Re: [RFC PATCH 2/2] staging:iio: Introduce IIO_CHAN_INFO_*_MASK References: <1319199855-24834-1-git-send-email-lars@metafoo.de> <1319199855-24834-2-git-send-email-lars@metafoo.de> In-Reply-To: <1319199855-24834-2-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/21/11 13:24, Lars-Peter Clausen wrote: > Introduce IIO_CHAN_INFO_*_MASK defines which can be used for specifying channel > a channel_spec info_mask attribute. This should be more convenient and also > more readable than creating the mask manually in each driver using the shift > operator. > Fair enough. Could call them IIO_CHAN_INFO_SCALE_SHARED_BIT etc? Marginally more accurate. MASK kind of implies multiple bits to my mind... > Signed-off-by: Lars-Peter Clausen > --- > Patch based on linux-iio/master > --- > drivers/staging/iio/iio.h | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/iio.h b/drivers/staging/iio/iio.h > index d7c5f3f..7ff8c98 100644 > --- a/drivers/staging/iio/iio.h > +++ b/drivers/staging/iio/iio.h > @@ -46,6 +46,43 @@ enum iio_chan_info_enum { > IIO_CHAN_INFO_AVERAGE_RAW_SEPARATE, > }; > > +#define IIO_CHAN_INFO_SCALE_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_SCALE_SHARED) > +#define IIO_CHAN_INFO_SCALE_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_SCALE_SEPARATE) > +#define IIO_CHAN_INFO_OFFSET_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_OFFSET_SHARED) > +#define IIO_CHAN_INFO_OFFSET_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_OFFSET_SEPARATE) > +#define IIO_CHAN_INFO_CALIBSCALE_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_CALIBSCALE_SHARED) > +#define IIO_CHAN_INFO_CALIBSCALE_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_CALIBSCALE_SEPARATE) > +#define IIO_CHAN_INFO_CALIBBIAS_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_CALIBBIAS_SHARED) > +#define IIO_CHAN_INFO_CALIBBIAS_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_CALIBBIAS_SEPARATE) > +#define IIO_CHAN_INFO_PEAK_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_PEAK_SHARED) > +#define IIO_CHAN_INFO_PEAK_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_PEAK_SEPARATE) > +#define IIO_CHAN_INFO_PEAK_SCALE_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_PEAK_SCALE_SHARED) > +#define IIO_CHAN_INFO_PEAK_SCALE_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_PEAK_SCALE_SHARED) > +#define IIO_CHAN_INFO_SCALE_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_SCALE_SHARED) > +#define IIO_CHAN_INFO_SCALE_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_SCALE_SEPARATE) > +#define IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW_SHARED) > +#define IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW_SEPARATE) > +#define IIO_CHAN_INFO_AVERAGE_RAW_SHARED_MASK \ > + BIT(IIO_CHAN_INFO_AVERAGE_RAW_SHARED) > +#define IIO_CHAN_INFO_AVERAGE_RAW_SEPARATE_MASK \ > + BIT(IIO_CHAN_INFO_AVERAGE_RAW_SEPARATE) > + > enum iio_endian { > IIO_CPU, > IIO_BE,