All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/8] libatomics-ops: force ARM mode
Date: Fri, 21 Oct 2011 09:45:58 -0500	[thread overview]
Message-ID: <4EA185A6.3050103@windriver.com> (raw)
In-Reply-To: <22ed6acc0a44d9bc0d6f7a2e800c039d77d75477.1319184832.git.Martin.Jansa@gmail.com>

On 10/21/11 3:17 AM, Martin Jansa wrote:
> * otherwise ie spitz (armv5te) build fails with:
> | make[3]: Entering directory `/OE/shr-core/tmp/work/armv5te-oe-linux-gnueabi/libatomics-ops-1.2-r5/libatomic_ops-1.2/src'
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops.c
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops_stack.c
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops_malloc.c
> | atomic_ops_malloc.c: In function 'msb':
> | atomic_ops_malloc.c:223:2: warning: right shift count >= width of type [enabled by default]
> | rm -f libatomic_ops_gpl.a
> | ar cru libatomic_ops_gpl.a atomic_ops_stack.o atomic_ops_malloc.o
> | arm-oe-linux-gnueabi-ranlib libatomic_ops_gpl.a
> | {standard input}: Assembler messages:
> | {standard input}:286: Error: selected processor does not support Thumb mode `swp r1,r2,[r3]'
> | {standard input}:329: Error: selected processor does not support Thumb mode `swp r0,r1,[r3]'
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  .../pulseaudio/libatomics-ops_1.2.bb               |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> index 05b22e8..4d9ca0d 100644
> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> @@ -20,4 +20,6 @@ S = "${WORKDIR}/libatomic_ops-${PV}"
>  
>  ALLOW_EMPTY_${PN} = "1"
>  
> +ARM_INSTRUCTION_SET = "arm"
> +
>  inherit autotools pkgconfig

Wouldn't it be better to fix libatomic-ops to have proper thumb mode assembly,
then fall back to non-thumb assembly?

I swear I had a patch to do this in the past, but I'm currently not able to find it.

--Mark



  parent reply	other threads:[~2011-10-21 14:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  8:17 [PATCH 0/8] Subversion-1.7.0 and arm/thumb work arounds Martin Jansa
2011-10-21  8:17 ` [PATCH 1/8] pulseaudio-0.9.23: inherit perlnative to work around build on host without XML/Parser.pm Martin Jansa
2011-10-21  8:17 ` [PATCH 2/8] libatomics-ops: force ARM mode Martin Jansa
2011-10-21  8:43   ` Henning Heinold
2011-10-21  8:48     ` Martin Jansa
2011-10-21 16:06       ` Khem Raj
2011-10-21 16:21         ` Martin Jansa
2011-10-21 14:45   ` Mark Hatle [this message]
2011-10-21  8:17 ` [PATCH 3/8] pulseaudio-0.9.23: " Martin Jansa
2011-10-21  8:29   ` Koen Kooi
2011-10-21 15:40   ` Khem Raj
2011-10-21 15:47     ` Koen Kooi
2011-10-21 16:16     ` Martin Jansa
2011-10-21 17:13       ` Saul Wold
2011-10-22 12:33       ` Phil Blundell
2011-10-25  7:26         ` Martin Jansa
2011-10-25 21:50           ` Phil Blundell
2011-10-21  8:17 ` [PATCH 4/8] webkit-gtk: force arm mode to work around binutils segfault Martin Jansa
2011-10-21 15:38   ` Khem Raj
2011-10-21  8:17 ` [PATCH 5/8] apr: add native support Martin Jansa
2011-10-21  8:17 ` [PATCH 6/8] neon: " Martin Jansa
2011-10-21  8:17 ` [PATCH 7/8] apr-util: " Martin Jansa
2011-10-21  8:17 ` [PATCH 8/8] subversion: add 1.7.0 with native support and negative D_P for now Martin Jansa
2011-10-21  9:48   ` [PATCH] base.bbclass: add subversion-native to DEPENDS if there is svn:// in SRC_URI Martin Jansa
2011-10-21 11:26     ` Martin Jansa
2011-10-21 13:11       ` [PATCH] subversion-1.6.15: add native support too Martin Jansa
2011-10-26 19:54         ` Saul Wold
2011-10-22 17:24     ` [PATCH] base.bbclass: add subversion-native to DEPENDS if there is svn:// in SRC_URI Saul Wold
2011-10-26 19:54 ` [PATCH 0/8] Subversion-1.7.0 and arm/thumb work arounds Saul Wold
2011-10-26 20:13   ` Martin Jansa
2011-11-07 19:13 ` Saul Wold
2011-11-07 22:34   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA185A6.3050103@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.