From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: The controlD device Date: Fri, 21 Oct 2011 21:16:25 +0200 Message-ID: <4EA1C509.40104@vmware.com> References: <4EA17C66.10207@vmware.com> <4EA197CF.4080108@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [65.115.85.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 19630A0E28 for ; Fri, 21 Oct 2011 12:18:39 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: Dave Airlie , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On 10/21/2011 06:48 PM, Dave Airlie wrote: >> Why do we have CONTROL_ALLOW on all modesetting ioctls?, also this code in >> drm_crtc.c seems odd: >> > The plan was to allow a master daemon to create seats and compute > nodes, on reflection it probably didn't need *all* the modesetting > ioctls, > just the GetResources one. > > So gdm or some equivalent would keep control over the control node, > and could be used to establish seats via render nodes. > Render nodes could have various crtc/outputs assigned to them. > A GPGPU render node would have 0 output pieces attached. > > >> if (file_priv->master->minor->type == DRM_MINOR_CONTROL) { >> ... >> >> Isn't that equivalent to >> >> if (file_priv->minor->type == DRM_MINOR_CONTROL) { ? >> > Yeah most likely just over thinking something. should be the same. > > I had a tree on k.org with this stuff more fleshed out, > I've just pushed it out here: > http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-render-nodes > > OK. Thanks. Got a better understanding what it's all about now. /Thomas > Dave. >