From: Robert Hancock <hancockrwd@gmail.com>
To: Dave Jones <davej@redhat.com>,
airlied@redhat.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [DRM] Lower the severity of the radeon lockup messages.
Date: Sat, 22 Oct 2011 01:17:13 -0600 [thread overview]
Message-ID: <4EA26DF9.8040903@gmail.com> (raw)
In-Reply-To: <20111021165101.GA27960@redhat.com>
On 10/21/2011 10:51 AM, Dave Jones wrote:
> abrt files a lot of bug reports when users get GPU lockups, but there's not really
> enough context to do anything useful with them. Given the lack of GPU context being
> dumped, this patch removes the stack trace, so that abrt ignores the messages.
>
> Signed-off-by: Dave Jones<davej@redhat.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
> index 7fd4e3e..a488b50 100644
> --- a/drivers/gpu/drm/radeon/radeon_fence.c
> +++ b/drivers/gpu/drm/radeon/radeon_fence.c
> @@ -263,7 +263,7 @@ retry:
> */
> if (seq == rdev->fence_drv.last_seq&& radeon_gpu_is_lockup(rdev)) {
> /* good news we believe it's a lockup */
> - WARN(1, "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
> + printk(KERN_WARNING "GPU lockup (waiting for 0x%08X last fence id 0x%08X)\n",
> fence->seq, seq);
> /* FIXME: what should we do ? marking everyone
> * as signaled for now
At the risk of sounding obvious, wouldn't it be better to enhance the
driver to dump out more useful debugging info in this case rather than
just suppressing the ABRT report?
next prev parent reply other threads:[~2011-10-22 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 16:51 [DRM] Lower the severity of the radeon lockup messages Dave Jones
2011-10-22 7:17 ` Robert Hancock [this message]
2011-10-22 7:19 ` David Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA26DF9.8040903@gmail.com \
--to=hancockrwd@gmail.com \
--cc=airlied@redhat.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.