Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 3140 bytes --]

On 2011-10-21 17:10, Aneesh Kumar K.V wrote:
> On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> Hi.
>>
>> Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers.
>> Error messages:
>>
>> In file included from trace.c:2:0:
>> trace.h: In function ‘trace_v9fs_attach’:
>> trace.h:2850:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_wstat’:
>> trace.h:3039:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_mkdir’:
>> trace.h:3088:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_mkdir_return’:
>> trace.h:3095:9: error: too many arguments for format [-Werror=format-extra-args]
>> cc1: all warnings being treated as errors
>>
>> Prototypes in the trace-events do not match format strings, e.g.
>>
>> v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* uname, char* aname) "tag %d id %d fid %d afid %d aname %s"
>>
>> The following patch fixes it, but I'm not sure the format lines are appropriate.
> 
> Can you send the patch with signed-off-by: I will add it in the next
> pull request.

There are more breakages with tracing enabled:

  CC    libhw64/9pfs/virtio-9p.o
cc1: warnings being treated as errors
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_create’:
/data/qemu/hw/9pfs/virtio-9p.c:2225:9: error: ‘iounit’ may be used uninitialized in this function                                                                                                                                            
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_readdir’:
/data/qemu/hw/9pfs/virtio-9p.c:2063:13: error: ‘count’ may be used uninitialized in this function                                                                                                                                            
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_xattrwalk’:
/data/qemu/hw/9pfs/virtio-9p.c:3103:13: error: ‘size’ may be used uninitialized in this function                                                                                                                                             
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_lcreate’:
/data/qemu/hw/9pfs/virtio-9p.c:1730:13: error: ‘iounit’ may be used uninitialized in this function                                                                                                                                           
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_open’:
/data/qemu/hw/9pfs/virtio-9p.c:1651:9: error: ‘iounit’ may be used uninitialized in this function                                                                                                                                            

Not sure what the undefined variables are supposed to contain for the
trace output, so I refrain from writing any patch.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]