All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiao.guangrong@qq.com>
To: Zhao Jin <cronozhj@gmail.com>
Cc: avi@redhat.com, mtosatti@redhat.com,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: MMU: fix the condition of syncing a new shadow page
Date: Mon, 24 Oct 2011 15:46:31 +0800	[thread overview]
Message-ID: <4EA517D7.6060407@qq.com> (raw)
In-Reply-To: <1319440880-2610-2-git-send-email-cronozhj@gmail.com>

On 2011/10/24 15:21, Zhao Jin wrote:
> Should be "or" since a new shadow page is synced if either it is
> not leaf or there already exists another unsync shadow page with 
> the same gfn.
> 

It is obviously wrong, we need to sync pages only if it has unsync page
*and* the new shadow page breaks the unsync rule(only the level 1 sp can
became unsync).

  reply	other threads:[~2011-10-24  7:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24  7:21 [PATCH] KVM: MMU: initialize sptes early Zhao Jin
2011-10-24  7:21 ` [PATCH] KVM: MMU: fix the condition of syncing a new shadow page Zhao Jin
2011-10-24  7:46   ` Xiao Guangrong [this message]
2011-10-24  9:04     ` Zhao Jin
2011-10-24  7:21 ` [PATCH] KVM: VMX: fix incorrect operand Zhao Jin
2011-10-24  7:41 ` [PATCH] KVM: MMU: initialize sptes early Xiao Guangrong
2011-10-24  9:01   ` Zhao Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA517D7.6060407@qq.com \
    --to=xiao.guangrong@qq.com \
    --cc=avi@redhat.com \
    --cc=cronozhj@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.