From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-161.synserver.de ([212.40.185.161]:1078 "HELO smtp-out-156.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1753477Ab1JXI3l (ORCPT ); Mon, 24 Oct 2011 04:29:41 -0400 Message-ID: <4EA5220A.6010301@metafoo.de> Date: Mon, 24 Oct 2011 10:30:02 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Jonathan Cameron CC: linux-iio@vger.kernel.org, michael.hennerich@analog.com, device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH] staging:iio:treewide only use shared to decide on interfaces References: <1319211579-14367-1-git-send-email-jic23@cam.ac.uk> <1319211579-14367-2-git-send-email-jic23@cam.ac.uk> In-Reply-To: <1319211579-14367-2-git-send-email-jic23@cam.ac.uk> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/21/2011 05:39 PM, Jonathan Cameron wrote: > Internally the fact that say scale is shared across channels is > actually of remarkably little interest. Hence lets not store it. > Numerous devices have weird combinations of channels sharing > scale anyway so it is not as though this was really telling > us much. Note however that we do still use the shared sysfs > attrs thus massively reducing the number of attrs in complex > drivers. > > Side effect is that certain drivers that were abusing this > (mostly my work) needed to do a few more checks on what the > channel they are being queried on actually is. > > This is also helpful for in kernel interfaces where we > just want to query the scale and don't care whether it > is shared with other channels or not. > > Signed-off-by: Jonathan Cameron Hi Seems to work. I think it makes sense to submit this one and the other, which removes the bitmask addressing, together. Will you take care of this? Thanks, - Lars