From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data Date: Mon, 24 Oct 2011 14:23:50 +0530 Message-ID: <4EA5279E.3000505@ti.com> References: <20111018132032.GD30703@S2100-06.ap.freescale.net> <4E9EB61C.1040207@ti.com> <20111019144215.GA32007@S2100-06.ap.freescale.net> <4E9FAF42.5060200@ti.com> <20111020061408.GE32007@S2100-06.ap.freescale.net> <4EA00F7C.1080005@ti.com> <20111021082309.GA337@S2100-06.ap.freescale.net> <4EA13053.7080306@ti.com> <20111021115809.GB337@S2100-06.ap.freescale.net> <4EA4FF6B.2080906@ti.com> <20111024081706.GC8708@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111024081706.GC8708@ponder.secretlab.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grant Likely Cc: patches@linaro.org, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, lrg@ti.com, Shawn Guo List-Id: linux-omap@vger.kernel.org On Monday 24 October 2011 01:47 PM, Grant Likely wrote: > On Mon, Oct 24, 2011 at 11:32:19AM +0530, Rajendra Nayak wrote: >> On Friday 21 October 2011 05:28 PM, Shawn Guo wrote: >>> On Fri, Oct 21, 2011 at 02:11:55PM +0530, Rajendra Nayak wrote: >>> [...] >>>>> + /* find device_node and attach it */ >>>>> + rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); Shawn/Mark, How about the driver passing the of_node to be associated with the regulator, as part of regulator_desc, to the regulator core, instead of this complete DT search and the restriction of having to match DT node names with names in regulator_desc. regards, Rajendra >>>> >>>> so would this do a complete dt search for every regulator? >>> >>> Yes, with the first param being NULL, tthe entire device tree will be >>> searched. >>> >>>> we would also need the driver names and dt names to match for this to >>>> work, right? >>>> >>> Driver name does not matter. The key for this search to work is having >>> regulator's name (regulator_desc->name) match device tree node's name, >>> case ignored. >> >> Mark, whats your take on this? I am somehow not quite sure if we should >> have this limitation put in to match DT node names with whats in the >> driver structs (regulator_desc). > > This looks wrong to me. Matching based on node /name/, particularly > when searching the entire tree, will cause problems. > > g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rnayak@ti.com (Rajendra Nayak) Date: Mon, 24 Oct 2011 14:23:50 +0530 Subject: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data In-Reply-To: <20111024081706.GC8708@ponder.secretlab.ca> References: <20111018132032.GD30703@S2100-06.ap.freescale.net> <4E9EB61C.1040207@ti.com> <20111019144215.GA32007@S2100-06.ap.freescale.net> <4E9FAF42.5060200@ti.com> <20111020061408.GE32007@S2100-06.ap.freescale.net> <4EA00F7C.1080005@ti.com> <20111021082309.GA337@S2100-06.ap.freescale.net> <4EA13053.7080306@ti.com> <20111021115809.GB337@S2100-06.ap.freescale.net> <4EA4FF6B.2080906@ti.com> <20111024081706.GC8708@ponder.secretlab.ca> Message-ID: <4EA5279E.3000505@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 24 October 2011 01:47 PM, Grant Likely wrote: > On Mon, Oct 24, 2011 at 11:32:19AM +0530, Rajendra Nayak wrote: >> On Friday 21 October 2011 05:28 PM, Shawn Guo wrote: >>> On Fri, Oct 21, 2011 at 02:11:55PM +0530, Rajendra Nayak wrote: >>> [...] >>>>> + /* find device_node and attach it */ >>>>> + rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); Shawn/Mark, How about the driver passing the of_node to be associated with the regulator, as part of regulator_desc, to the regulator core, instead of this complete DT search and the restriction of having to match DT node names with names in regulator_desc. regards, Rajendra >>>> >>>> so would this do a complete dt search for every regulator? >>> >>> Yes, with the first param being NULL, tthe entire device tree will be >>> searched. >>> >>>> we would also need the driver names and dt names to match for this to >>>> work, right? >>>> >>> Driver name does not matter. The key for this search to work is having >>> regulator's name (regulator_desc->name) match device tree node's name, >>> case ignored. >> >> Mark, whats your take on this? I am somehow not quite sure if we should >> have this limitation put in to match DT node names with whats in the >> driver structs (regulator_desc). > > This looks wrong to me. Matching based on node /name/, particularly > when searching the entire tree, will cause problems. > > g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953Ab1JXIyA (ORCPT ); Mon, 24 Oct 2011 04:54:00 -0400 Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:48414 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753773Ab1JXIx7 (ORCPT ); Mon, 24 Oct 2011 04:53:59 -0400 Message-ID: <4EA5279E.3000505@ti.com> Date: Mon, 24 Oct 2011 14:23:50 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110805 Thunderbird/3.1.12 MIME-Version: 1.0 To: Grant Likely CC: Shawn Guo , broonie@opensource.wolfsonmicro.com, patches@linaro.org, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, lrg@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data References: <20111018132032.GD30703@S2100-06.ap.freescale.net> <4E9EB61C.1040207@ti.com> <20111019144215.GA32007@S2100-06.ap.freescale.net> <4E9FAF42.5060200@ti.com> <20111020061408.GE32007@S2100-06.ap.freescale.net> <4EA00F7C.1080005@ti.com> <20111021082309.GA337@S2100-06.ap.freescale.net> <4EA13053.7080306@ti.com> <20111021115809.GB337@S2100-06.ap.freescale.net> <4EA4FF6B.2080906@ti.com> <20111024081706.GC8708@ponder.secretlab.ca> In-Reply-To: <20111024081706.GC8708@ponder.secretlab.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 24 October 2011 01:47 PM, Grant Likely wrote: > On Mon, Oct 24, 2011 at 11:32:19AM +0530, Rajendra Nayak wrote: >> On Friday 21 October 2011 05:28 PM, Shawn Guo wrote: >>> On Fri, Oct 21, 2011 at 02:11:55PM +0530, Rajendra Nayak wrote: >>> [...] >>>>> + /* find device_node and attach it */ >>>>> + rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); Shawn/Mark, How about the driver passing the of_node to be associated with the regulator, as part of regulator_desc, to the regulator core, instead of this complete DT search and the restriction of having to match DT node names with names in regulator_desc. regards, Rajendra >>>> >>>> so would this do a complete dt search for every regulator? >>> >>> Yes, with the first param being NULL, tthe entire device tree will be >>> searched. >>> >>>> we would also need the driver names and dt names to match for this to >>>> work, right? >>>> >>> Driver name does not matter. The key for this search to work is having >>> regulator's name (regulator_desc->name) match device tree node's name, >>> case ignored. >> >> Mark, whats your take on this? I am somehow not quite sure if we should >> have this limitation put in to match DT node names with whats in the >> driver structs (regulator_desc). > > This looks wrong to me. Matching based on node /name/, particularly > when searching the entire tree, will cause problems. > > g.