From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-161.synserver.de ([212.40.185.161]:1066 "EHLO smtp-out-161.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355Ab1JXI6A (ORCPT ); Mon, 24 Oct 2011 04:58:00 -0400 Message-ID: <4EA528B6.1030300@metafoo.de> Date: Mon, 24 Oct 2011 10:58:30 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Jonathan Cameron CC: linux-iio@vger.kernel.org, michael.hennerich@analog.com, device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH] staging:iio:treewide only use shared to decide on interfaces References: <1319211579-14367-1-git-send-email-jic23@cam.ac.uk> <1319211579-14367-2-git-send-email-jic23@cam.ac.uk> <4EA5220A.6010301@metafoo.de> <4EA522D3.9000906@cam.ac.uk> In-Reply-To: <4EA522D3.9000906@cam.ac.uk> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/24/2011 10:33 AM, Jonathan Cameron wrote: > On 10/24/11 09:30, Lars-Peter Clausen wrote: >> On 10/21/2011 05:39 PM, Jonathan Cameron wrote: >>> Internally the fact that say scale is shared across channels is >>> actually of remarkably little interest. Hence lets not store it. >>> Numerous devices have weird combinations of channels sharing >>> scale anyway so it is not as though this was really telling >>> us much. Note however that we do still use the shared sysfs >>> attrs thus massively reducing the number of attrs in complex >>> drivers. >>> >>> Side effect is that certain drivers that were abusing this >>> (mostly my work) needed to do a few more checks on what the >>> channel they are being queried on actually is. >>> >>> This is also helpful for in kernel interfaces where we >>> just want to query the scale and don't care whether it >>> is shared with other channels or not. >>> >>> Signed-off-by: Jonathan Cameron >> >> Hi >> >> Seems to work. I think it makes sense to submit this one and the other, >> which removes the bitmask addressing, together. Will you take care of this? > Yes. Might take a few days to hit though as I would guess Greg is going > to be busy at the kernel summit. > > Are you happy to Ack this patch or if not give a tested-by. > Whilst I can push stuff on without review to Greg, I always prefer not to! > > Jonathan Acked-by: Lars-Peter Clausen