All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Pekka Enberg" <penberg@kernel.org>,
	linux-sparse@vger.kernel.org,
	"Christopher Li" <sparse@chrisli.org>,
	"Jeff Garzik" <jgarzik@redhat.com>
Subject: Re: [PATCH] sparse, llvm: Fix 'void *' pointer code generation
Date: Mon, 24 Oct 2011 11:13:58 -0400	[thread overview]
Message-ID: <4EA580B6.4070008@garzik.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1110241532340.14239@tux.localdomain>

On 10/24/2011 08:33 AM, Pekka Enberg wrote:
>> On Mon, Oct 24, 2011 at 02:56:41PM +0300, Pekka Enberg wrote:
>>> Fix the issue by switching to LLVMIntType(bits_per_pointer) in
>>> sym_basetype_type().
>
> On Mon, 24 Oct 2011, Jonathan Neuschäfer wrote:
>> You didn't update the commit message.
>
> Thanks for pointing that out. Jeff, does this look OK?

I don't know what bit_size==-1 means off the top of my head, so I assume 
yes ;-)

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-10-24 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 11:43 [PATCH] sparse, llvm: Fix 'void *' pointer code generation Pekka Enberg
2011-10-24 11:52 ` Linus Torvalds
2011-10-24 11:56   ` Pekka Enberg
2011-10-24 12:14     ` Jonathan Neuschäfer
2011-10-24 12:33       ` Pekka Enberg
2011-10-24 15:13         ` Jeff Garzik [this message]
2011-10-24 15:18           ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA580B6.4070008@garzik.org \
    --to=jeff@garzik.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=jgarzik@redhat.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=penberg@kernel.org \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.