From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <nataraja@qca.qualcomm.com>,
<athiruve@qca.qualcomm.com>
Subject: Re: [PATCH 34/34] ath6kl: Enable not more than one interface to workaround target assert
Date: Tue, 25 Oct 2011 15:46:04 +0300 [thread overview]
Message-ID: <4EA6AF8C.20206@qca.qualcomm.com> (raw)
In-Reply-To: <20111025120539.GA22698@vasanth-laptop>
On 10/25/2011 03:05 PM, Vasanthakumar Thiagarajan wrote:
> On Tue, Oct 25, 2011 at 02:43:11PM +0300, Kalle Valo wrote:
>> On 10/25/2011 01:10 PM, Vasanthakumar Thiagarajan wrote:
>>> Configuring the firmware for three interfaces causes random
>>> target assert. So restrict the number of vifs to just 1 to avoid
>>> this issue for now. Once it is fixed in firmware, this patch
>>> would be reverted.
>>
>> Patches 32-34 are problematic. They are changing functionality of
>> patches earlier in the series. (I guess you created those patches
>> later.) Instead you should edit the original patches, not just add
>> extra patches on top.
>
> Patch 32 and 33 are clean ups, i don't think integrating these
> changes into respective patches would be trivial with the number of
> patches that need to be rebased after the change.
Yeah, that's always a problem when you are sending a huge patchset like
this. A solution for this is to work split work to smaller patches, that
way changes in patches would cause less work.
> So I can drop these two patches and send them sometime later.
Dropping doesn't make any difference here actually, still the original
code needing for cleanup will stay in the history.
> Regarding patch 34, the target configuration changes needed for multi
> vif are done in more than one patches and integrating this change
> into those changes would not make sense to those configurations. Let
> me see how I can integrate this.
Thanks.
Kalle
prev parent reply other threads:[~2011-10-25 12:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 10:09 [PATCH 00/34] ath6kl Add multiple vif support Vasanthakumar Thiagarajan
2011-10-25 10:09 ` [PATCH 01/34] ath6kl: Pass ath6kl structure to ath6kl_init() instead of net_device Vasanthakumar Thiagarajan
2011-10-25 10:09 ` [PATCH 02/34] ath6kl: Keep wiphy reference in ath6kl structure Vasanthakumar Thiagarajan
2011-10-25 10:09 ` [PATCH 03/34] ath6kl: Refactor wiphy dev and net dev init functions Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 04/34] ath6kl: Cleanup fw interface type setting Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 05/34] ath6kl: Define an initial vif structure and use it Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 06/34] ath6kl: Define interface specific states Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 07/34] ath6kl: Move ssid and crypto information to vif structure Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 08/34] ath6kl: Move nw_type " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 09/34] ath6kl: Move bssid information " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 10/34] ath6kl: Move channel " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 11/34] ath6kl: Move key " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 12/34] ath6kl: Move aggregation " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 13/34] ath6kl: Move disconnect timer " Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 14/34] ath6kl: Move scan_req info and sme_state to vif Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 15/34] ath6kl: Move few more vif specific information to struct ath6kl_vif Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 16/34] ath6kl: Make net and target stats vif specific Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 17/34] ath6kl: Maintain firmware interface index in struct ath6kl_vif Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 18/34] ath6kl: Take vif information from wmi event Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 19/34] ath6kl: Remove net_device from ath6kl Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 20/34] ath6kl: Cleanup parameters in ath6kl_init_control_info() and ath6kl_init_profile_info() Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 21/34] ath6kl: Refactor ath6kl_destroy() Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 22/34] ath6kl: Use interface index from wmi data headr Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 23/34] ath6kl: Store hw mac address in struct ath6kl Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 24/34] ath6kl: Introduce spinlock to protect vif specific information Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 25/34] ath6kl: Maintain virtual interface in a list Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 26/34] ath6kl: Use the other variant of netdev (un)register APIs Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 27/34] ath6kl: Configure inteface information for multi vif support Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 28/34] ath6kl: Implement add_virtual_intf() and del_virtual_intf() Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 29/34] ath6kl: Add a modparam to enable multi normal interface support Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 30/34] ath6kl: Initialize target wlan values for every vif Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 31/34] ath6kl: Use appropriate wdev from vif Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 32/34] ath6kl: Cleanup few function parametrs in cfg80211.c Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 33/34] ath6kl: Cleanup function parameters in ath6kl_init_if_data()/ath6kl_deinit_if_data() Vasanthakumar Thiagarajan
2011-10-25 10:10 ` [PATCH 34/34] ath6kl: Enable not more than one interface to workaround target assert Vasanthakumar Thiagarajan
2011-10-25 11:43 ` Kalle Valo
2011-10-25 12:05 ` Vasanthakumar Thiagarajan
2011-10-25 12:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA6AF8C.20206@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=athiruve@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nataraja@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.