All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Sung <jesse.sung@canonical.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-bluetooth@vger.kernel.org, 812132@bugs.launchpad.net
Subject: Re: [PATCH] Bluetooth: set reset_resume handler
Date: Tue, 25 Oct 2011 22:48:59 +0800	[thread overview]
Message-ID: <4EA6CC5B.2020400@canonical.com> (raw)
In-Reply-To: <201110251343.49236.oneukum@suse.de>

On 10/25/2011 07:43 PM, Oliver Neukum wrote:
> Am Dienstag, 25. Oktober 2011, 13:20:13 schrieb Jesse Sung:
>> On 10/25/2011 04:40 PM, Oliver Neukum wrote:
>>> Am Dienstag, 25. Oktober 2011, 10:37:38 schrieb Jesse Sung:
>>>>
>>>> On some machines, it seems that usb hubs do not get power while
>>>> being suspended. We can get something like this in dmesg:
>>>>        usb usb2: root hub lost power or was reset
>>>>
>>>> When this is the case, .reset_resume is called instead of .resume.
>>>> If .reset_resume is not set, bluetooth modules would stay in an unusable
>>>> state because the resume function is not called.
>>>
>>> Have you experimentally verified that? This state of affairs is years
>>> old and should result in a virtual unplug/replug cycle. What are you
>>> seeing?
>>
>> Hi Oliver,
>>
>> Humm... You're right, there is an unplug-replug cycle, but bluetooth
>> doesn't work until I restart bluetoothd. If the resume function is
>> called through .reset_resume, then bluetooth works right after resume.
>
> Hi
>
> Yes, but we fail to indicate to user space that connections may have been
> dropped. I doubt we can simply pretend the loss of power hasn't occured.
> Have you tested what happens if you go to S3 while eg. a file is transfered
> or audio played with your patch?

Hi Oliver,

Indeed, loss of power event should not be ignored.

Just tested file transferring. If there's no active connection, 
everything goes fine. But if a file is transferring while going to S3, 
bluetooth is not working after resume. Use applet to disable and 
re-enable bluetooth makes it work again...

Wondering what is the right way to handle loss of power...

Regards,
Jesse

  reply	other threads:[~2011-10-25 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  8:37 [PATCH] Bluetooth: set reset_resume handler Jesse Sung
2011-10-25  8:40 ` Oliver Neukum
2011-10-25 11:20   ` Jesse Sung
2011-10-25 11:43     ` Oliver Neukum
2011-10-25 14:48       ` Jesse Sung [this message]
2011-10-25 18:29         ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA6CC5B.2020400@canonical.com \
    --to=jesse.sung@canonical.com \
    --cc=812132@bugs.launchpad.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=oneukum@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.