From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIihQ-0000KU-1X for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIihK-0007GZ-3l for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:13:56 -0400 Received: from mail.mc.net ([209.172.128.24]:50199) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RIihJ-0007GC-WE for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:13:50 -0400 Message-ID: <4EA6D268.50509@mc.net> Date: Tue, 25 Oct 2011 10:14:48 -0500 From: Bob Breuer MIME-Version: 1.0 References: <4E9BB180.6080506@mc.net> <4E9C0497.2000605@siriusit.co.uk> <4E9C3703.3040109@mc.net> <4E9C645A.5060200@twiddle.net> <4E9C9C08.20001@mc.net> <4E9CAACE.4070804@mc.net> <4E9F3BB4.3050604@mc.net> <4EA57A26.1050806@mc.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kai Tietz Cc: "gcc@gcc.gnu.org" , xunxun , qemu-devel , Mark Cave-Ayland , Richard Henderson Kai Tietz wrote: > 2011/10/24 Bob Breuer : >> Kai Tietz wrote: >>> Hi, >>> >>> For trunk-version I have a tentative patch for this issue. On 4.6.x >>> and older branches this doesn't work, as here we can't differenciate >>> that easy between ms- and sysv-abi. >>> >>> But could somebody give this patch a try? >>> >>> Regards, >>> Kai >>> >>> ChangeLog >>> >>> * config/i386/i386.c (ix86_frame_pointer_required): Enforce use of >>> frame-pointer for 32-bit ms-abi, if setjmp is used. >>> >>> Index: i386.c >>> =================================================================== >>> --- i386.c (revision 180099) >>> +++ i386.c (working copy) >>> @@ -8391,6 +8391,10 @@ >>> if (SUBTARGET_FRAME_POINTER_REQUIRED) >>> return true; >>> >>> + /* For older 32-bit runtimes setjmp requires valid frame-pointer. */ >>> + if (TARGET_32BIT_MS_ABI && cfun->calls_setjmp) >>> + return true; >>> + >>> /* In ix86_option_override_internal, TARGET_OMIT_LEAF_FRAME_POINTER >>> turns off the frame pointer by default. Turn it back on now if >>> we've not got a leaf function. */ >>> >> For a gcc 4.7 snapshot, this does fix the longjmp problem that I >> encountered. So aside from specifying -fno-omit-frame-pointer for >> affected files, what can be done for 4.6? >> >> Bob > > Well, for 4.6.x (or older) we just can use the mingw32.h header in > gcc/config/i386/ and define here a subtarget-macro to indicate that. > The only incompatible point here might be for Wine using the > linux-compiler to build Windows related code. > > A possible patch for 4.6 gcc versions I attached to this mail. > > Regards, > Kai > > Index: mingw32.h > =================================================================== > --- mingw32.h (revision 180393) > +++ mingw32.h (working copy) > @@ -239,3 +239,8 @@ > /* We should find a way to not have to update this manually. */ > #define LIBGCJ_SONAME "libgcj" /*LIBGCC_EH_EXTN*/ "-12.dll" > > +/* For 32-bit Windows we need valid frame-pointer for function using > + setjmp. */ > +#define SUBTARGET_SETJMP_NEED_FRAME_POINTER \ > + (!TARGET_64BIT && cfun->calls_setjmp) > + > Index: i386.c > =================================================================== > --- i386.c (revision 180393) > +++ i386.c (working copy) > @@ -8741,6 +8741,12 @@ > if (SUBTARGET_FRAME_POINTER_REQUIRED) > return true; > > +#ifdef SUBTARGET_SETJMP_NEED_FRAME_POINTER > + /* For older 32-bit runtimes setjmp requires valid frame-pointer. */ > + if (SUBTARGET_SETJMP_NEED_FRAME_POINTER) > + return true; > +#endif > + > /* In ix86_option_override_internal, TARGET_OMIT_LEAF_FRAME_POINTER > turns off the frame pointer by default. Turn it back on now if > we've not got a leaf function. */ > That works for me. Thanks. Bob