From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RIj0U-0007JU-I1
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:33:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RIj0T-0002R0-56
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:33:38 -0400
Received: from cantor2.suse.de ([195.135.220.15]:44804 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RIj0S-0002Oa-KM
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:33:36 -0400
Message-ID: <4EA6D6C4.1050108@suse.de>
Date: Tue, 25 Oct 2011 17:33:24 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1319550280.git.quintela@redhat.com>
	<2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
In-Reply-To: <2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures
 export a way to migrate cpu's
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Am 25.10.2011 16:00, schrieb Juan Quintela:
> This makes several changes:
> - exports VMStateDescription vmstate_cpu non-static.
> - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined
> - for the architecture that had nothing, it just register the cpu as un=
migratable.
> - Depending on CPU_SAVE_VERSION we register old/new migration style
>=20
> Signed-off-by: Juan Quintela <quintela@redhat.com>

I like that move in general.

> diff --git a/target-m68k/machine.c b/target-m68k/machine.c
> index e69de29..86b6fe9 100644
> --- a/target-m68k/machine.c
> +++ b/target-m68k/machine.c
> @@ -0,0 +1,10 @@
> +
> +#include "hw/hw.h"
> +
> +/* To make this architecture migratable, we need to define cpu state
> +   here.  Other things need to be done elsewhere */
> +
> +const VMStateDescription vmstate_cpu =3D {
> +    .name =3D "cpu",
> +    .unmigratable =3D 1,
> +};

Here ...

> diff --git a/target-sh4/machine.c b/target-sh4/machine.c
> index e69de29..86b6fe9 100644
> --- a/target-sh4/machine.c
> +++ b/target-sh4/machine.c
> @@ -0,0 +1,10 @@
> +
> +#include "hw/hw.h"
> +
> +/* To make this architecture migratable, we need to define cpu state
> +   here.  Other things need to be done elsewhere */
> +
> +const VMStateDescription vmstate_cpu =3D {
> +    .name =3D "cpu",
> +    .unmigratable =3D 1,
> +};

... and here you sort-of create new files (empty before) without a
license header. The contents is trivial right now, but it would get a
case for the Wiki trying to figure out what license to put on other
people's code.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg