From: Kyle Manna <kyle.manna@fuel7.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices
Date: Tue, 25 Oct 2011 11:20:06 -0500 [thread overview]
Message-ID: <4EA6E1B6.9050608@fuel7.com> (raw)
In-Reply-To: <20111025160117.GA634@sirena.org.uk>
On 10/25/2011 11:01 AM, Mark Brown wrote:
>> Unfortunately on this chip there aren't any identification or
>> > constant test registers. The only register close is the
>> > JTAGVERNUM_REG and that's will change across silicon revisions.
> It seems like a more useful implementation would be to have the driver
> read and display this revision number during boot, this will give you
> the register readability check and also let us know the device revision
> which might be useful for diagnostics.
I reviewed the register and the lowest 4 bits are the silicon revision
(my hw reads 0x1) and the upper four bits should always be zero. I will
update the patch to silently succeed as long a valid value is read, else
print a error including that value and return -ENODEV.
Should I submit an entire updated patch series or just submit a single
patch in reply to this? Did you have any other comments on the rest of
the series?
- Kyle
next prev parent reply other threads:[~2011-10-25 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 17:05 [PATCH v2 0/6] mfd: TPS65910: Bug fixes and enhancements Kyle Manna
2011-10-24 17:05 ` [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices Kyle Manna
2011-10-25 7:14 ` Mark Brown
2011-10-25 15:10 ` Kyle Manna
2011-10-25 16:01 ` Mark Brown
2011-10-25 16:20 ` Kyle Manna [this message]
2011-10-26 15:00 ` Mark Brown
2011-10-24 17:06 ` [PATCH v2 2/6] mfd: TPS65910: Add I2C slave address macros Kyle Manna
2011-10-24 17:06 ` [PATCH v2 3/6] mfd: TPS65910: Fix typo that clobbers genirq Kyle Manna
2011-10-24 17:06 ` [PATCH v2 4/6] mfd: TPS65910: Move linux/gpio.h include to header Kyle Manna
2011-10-24 17:06 ` [PATCH v2 5/6] mfd: TPS65910: Move regulator defs " Kyle Manna
2011-10-25 7:23 ` Mark Brown
2011-10-24 17:06 ` [PATCH v2 6/6] mfd: TPS65910: Create an array for reg init data Kyle Manna
2011-10-25 7:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA6E1B6.9050608@fuel7.com \
--to=kyle.manna@fuel7.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.