From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED
Date: Tue, 25 Oct 2011 19:30:38 -0400 [thread overview]
Message-ID: <4EA7469E.5060705@redhat.com> (raw)
In-Reply-To: <4E77A6F7.5090607@redhat.com>
On 09/19/2011 04:32 PM, Lon Hohberger wrote:
> On 09/13/2011 04:44 AM, Kazunori INOUE wrote:
>
>> I attached the patch for this problem.
>>
>> * Modified to send a SIGHUP to the primary thread from the secondary
>> thread detects the start of the VM, and
>> the primary thread is modified so as to select() the requests from
>> the VM which started.
>
> That's certainly one way of doing it. I might have used
> 'pthread_cond_singal'.
I am sorry for the delay.
I have a fix based on yours that uses a pipe to wake up select() rather
than pthread_kill; I'll attach it here. This ends up being a bit lower
impact, as well; it doesn't require changing the main program - only the
serial/vmchannel plugin.
Apart from that, the patch here is largely the same.
Let me know what you think at your convenience.
-- Lon
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-serial-domain-handling.patch
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20111025/d7b5bd33/attachment.ksh>
next prev parent reply other threads:[~2011-10-25 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 8:44 [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED Kazunori INOUE
2011-09-19 20:32 ` Lon Hohberger
2011-10-25 23:30 ` Lon Hohberger [this message]
2011-10-27 7:23 ` Kazunori INOUE
2011-11-22 9:31 ` Kazunori INOUE
2012-02-07 23:17 ` Lon Hohberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA7469E.5060705@redhat.com \
--to=lhh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.