From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature
Date: Wed, 26 Oct 2011 10:07:32 +0800 [thread overview]
Message-ID: <4EA76B64.50302@wytron.com.tw> (raw)
In-Reply-To: <4EA67199.2060704@missinglinkelectronics.com>
On 10/25/2011 04:21 PM, Joachim Foerster wrote:
> Hi all,
>
> Did anybody get a chance to review those 5 small patches? I would like
> to get some feedback and work on it, if needed - to get them upstream.
>
Hi Joachim,
I forwarded your patches to Dalon Westergreen of Altera on Oct 20, who
is the author of this driver. I asked Dalon to help to review your patches.
I run checkpatch.pl and there are minors warnings. You may fix them
after we get feedback from Dalon.
WARNING: braces {} are not necessary for any arm of this statement
#55: FILE: drivers/net/altera_tse.c:586:
+ if ((priv->flags >= 1) && (priv->flags <= 4)) {
[...]
+ } else if (priv->flags == 5) {
[...]
WARNING: braces {} are not necessary for single statement blocks
#68: FILE: drivers/net/altera_tse.c:598:
+ if ((priv->flags >= 1) && (priv->flags <= 4)) {
+ mii_data |= 0x82;
+ }
I am going to test your patches on 3C120 and NEEK boards. And will let
you know my results.
Best regards,
Thomas
next prev parent reply other threads:[~2011-10-26 2:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:24 [U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature Joachim Foerster
2011-10-17 15:24 ` [U-Boot] [PATCH 1/5] altera_tse: Clear SGDMA's RUN bit in async case, too Joachim Foerster
2011-10-17 15:24 ` [U-Boot] [PATCH 2/5] altera_tse: Fix SGDMA reset triggering Joachim Foerster
2011-10-17 15:24 ` [U-Boot] [PATCH 3/5] altera_tse: Add support for dedicated descriptor memory Joachim Foerster
2011-10-17 15:24 ` [U-Boot] [PATCH 4/5] altera_tse: m88e1111s: Honor device flags regarding PHY interface mode Joachim Foerster
2011-10-17 15:24 ` [U-Boot] [PATCH 5/5] altera_tse: Fix return of eth_device's recv() callback Joachim Foerster
2011-10-25 8:21 ` [U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature Joachim Foerster
2011-10-25 12:24 ` Scott McNutt
2011-10-26 2:07 ` Thomas Chou [this message]
2011-10-26 8:39 ` Joachim Foerster
2011-10-26 8:39 ` [U-Boot] [PATCH 0/5 v2] " Joachim Foerster
2011-10-26 8:39 ` [U-Boot] [PATCH 1/5 v2] altera_tse: Clear SGDMA's RUN bit in async transfer, like in sync case Joachim Foerster
2011-10-26 19:26 ` Wolfgang Denk
2011-10-26 8:39 ` [U-Boot] [PATCH 2/5 v2] altera_tse: Fix SGDMA reset triggering Joachim Foerster
2011-10-26 19:27 ` Wolfgang Denk
2011-10-26 8:39 ` [U-Boot] [PATCH 3/5 v2] altera_tse: Add support for dedicated descriptor memory Joachim Foerster
2011-10-26 19:28 ` Wolfgang Denk
2011-10-26 8:39 ` [U-Boot] [PATCH 4/5 v2] altera_tse: m88e1111s: Honor device flags regarding PHY interface mode Joachim Foerster
2011-10-26 19:28 ` Wolfgang Denk
2011-10-26 8:39 ` [U-Boot] [PATCH 5/5 v2] altera_tse: Fix return of eth_device's recv() callback Joachim Foerster
2011-10-26 19:29 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA76B64.50302@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.