From: Jens Axboe <axboe@kernel.dk>
To: Steven Lang <tirea@google.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Fix segfault with verify_async
Date: Wed, 26 Oct 2011 09:51:29 +0200 [thread overview]
Message-ID: <4EA7BC01.2080500@kernel.dk> (raw)
In-Reply-To: <CAAUT-yMxJ5_m4VPKohuoLj7CHAqpdOT2_17NZ5F86GM-1+xW-A@mail.gmail.com>
On 2011-10-25 22:23, Steven Lang wrote:
> At some point the filename was added to the report on verify failures,
> however this broke verify_async, as the file pointer on the io_u is
> set to NULL before the verify thread sees the io_u. The result is a
> segfault when there is a verify mismatch.
>
> This patch changes the semantics of a deferred free (IO_U_F_FREE_DEF)
> to have already called put_file, but not set the file pointer to NULL.
> This is safe to do as the file list is only freed after all the
> verify threads have been terminated.
Thanks Steven, good catch. Applied.
--
Jens Axboe
prev parent reply other threads:[~2011-10-26 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:23 [PATCH] Fix segfault with verify_async Steven Lang
2011-10-25 21:00 ` Steven Lang
2011-10-26 7:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA7BC01.2080500@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=tirea@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.