From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: Include a version of bsd's queue.h Date: Wed, 26 Oct 2011 10:14:46 +0200 Message-ID: <4EA7C176.3020704@amd.com> References: <20134.62279.50041.126603@mariner.uk.xensource.com> <20134.63697.38240.276236@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20134.63697.38240.276236@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Anthony PERARD , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 10/25/11 19:58, Ian Jackson wrote: > Ian Jackson writes ("[Xen-devel] [PATCH] libxl: Include a version of bsd's queue.h"): >> We would like some linked list macros which are (a) well known to be >> sane and (b) typesafe. BSD's queue.h meets these criteria. >> >> The files in this changeset were obtained with: >> svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/ >> svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3 > > I posted this because I noticed (too late) that libxl_qmp.c includes > and uses some macros that are only available in some > queue.h versions. This is not ideal for portability of course. > > I think it would be good to include this massaged queue.h and use it > in libxl_qmp.c. These headers cause build errors on *BSD due to collisions with the native headers. Two solutions: - Only use them on platforms where they do not exist - Add a namespace prefix to the macros and use them consequently Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632