Re: [PATCH] libxl: Include a version of bsd's queue.h

[Christoph Egger <Christoph.Egger@amd.com>]

On 10/26/11 10:22, Ian Campbell wrote:
> On Wed, 2011-10-26 at 09:14 +0100, Christoph Egger wrote:
>> On 10/25/11 19:58, Ian Jackson wrote:
>>> Ian Jackson writes ("[Xen-devel] [PATCH] libxl: Include a version of bsd's queue.h"):
>>>> We would like some linked list macros which are (a) well known to be
>>>> sane and (b) typesafe.  BSD's queue.h meets these criteria.
>>>>
>>>> The files in this changeset were obtained with:
>>>>     svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/
>>>>     svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3
>>>
>>> I posted this because I noticed (too late) that libxl_qmp.c includes
>>> <sys/queue.h>   and uses some macros that are only available in some
>>> queue.h versions.  This is not ideal for portability of course.
>>>
>>> I think it would be good to include this massaged queue.h and use it
>>> in libxl_qmp.c.
>>
>> These headers cause build errors on *BSD due to collisions with the
>> native headers. Two solutions:
>>
>> - Only use them on platforms where they do not exist
>> - Add a namespace prefix to the macros and use them consequently
>
> Ian provided a script which adds a namespace to these files at build
> time, or at least was supposed to. If it isn't working properly then we
> need to see the actual failures you are seeing.

Ah, ok. I missed the script on review.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632