From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4EA7F599.4000304@domain.hid> Date: Wed, 26 Oct 2011 13:57:13 +0200 From: Philippe Gerum MIME-Version: 1.0 References: <68d35b0c2502bcfcd82a.1318861191@domain.hid> <4EA7DF14.6050307@domain.hid> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai-help] [PATCH 2 of 4] psos: port long_names feature to xenomai-forge List-Id: Help regarding installation and common use of Xenomai List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas De Schampheleire Cc: xenomai@xenomai.org On 10/26/2011 12:41 PM, Thomas De Schampheleire wrote: > On Wed, Oct 26, 2011 at 12:21 PM, Philippe Gerum wrote: >> On 10/19/2011 09:35 AM, Thomas De Schampheleire wrote: >>> >>> While psos interface accepts 4 character ids, non null terminated, >>> xenomai uses longer ids which must be null terminated. Revert to >>> the behaviour of psos interface, while allowing long id strings if >>> the global variable psos_long_names is set to non-zero. >>> >>> This patch ports the original fix from xenomai to xenomai-forge, >>> fixing following problems: >>> * a bug in __psos_maybe_short_name so that only 3 characters are >>> retained >>> * the call to __psos_maybe_short_name also needs to be done in the >>> ident functions >>> * the pt_create and pt_ident functions also need to be adapted >>> >> >> Please merge long_names.h into psos.h, having a separate header for this is >> way overkill and brings nothing. > > It avoids exposing an internal interface to applications through psos.h. > If anything, I think we should make a psos_internal.h or whatever, > that can host __psos_maybe_short_name among others. Yes, that would be better. include/psos is really for external stuff anyway. lib/psos/internal.h would make sense. > > ~Thomas > -- Philippe.