Re: [PATCH 2/2] staging:iio:dac: Add AD5421 driver

[Lars-Peter Clausen <lars@metafoo.de>]

On 10/26/2011 02:01 PM, Lars-Peter Clausen wrote:
> This patch adds support for the Analog Devices AD5421 Loop-Powered, 4mA to 20mA
> DAC.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> [...]
>
>  drivers/staging/iio/events.h     |    3 +-
>  
> [...]
> diff --git a/drivers/staging/iio/events.h b/drivers/staging/iio/events.h
> index 7cf9306..2b4d2d9 100644
> --- a/drivers/staging/iio/events.h
> +++ b/drivers/staging/iio/events.h
> @@ -56,7 +56,8 @@ enum iio_event_direction {
>  		       type, chan, chan1, chan2)			\
>  	(((u64)type << 56) | ((u64)diff << 55) |			\
>  	 ((u64)direction << 48) | ((u64)modifier << 40) |		\
> -	 ((u64)chan_type << 32) | (chan2 << 16) | chan1 | chan)
> +	 ((u64)chan_type << 32) | (((s16)chan2) << 16) | ((s16)chan1) | \
> +	 ((s16)chan))
>  

Uhm, this was not supposed to be in this patch...

>  
>  #define IIO_EV_DIR_MAX 4