From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ5wO-00078Z-NY for qemu-devel@nongnu.org; Wed, 26 Oct 2011 12:03:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ5wH-0004vs-KN for qemu-devel@nongnu.org; Wed, 26 Oct 2011 12:02:56 -0400 Received: from thoth.sbs.de ([192.35.17.2]:27185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ5wH-0004vW-6S for qemu-devel@nongnu.org; Wed, 26 Oct 2011 12:02:49 -0400 Message-ID: <4EA82F24.1090301@siemens.com> Date: Wed, 26 Oct 2011 18:02:44 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20111003163352.GA22822@davesworkthinkpad> <4E89F62E.1020804@web.de> <87lit0n66z.fsf@ginnungagap.bsc.es> <4E8B41D8.3050502@web.de> <4E8C0275.50107@redhat.com> <4E8C0CA0.2010006@web.de> <4E8C217D.10800@redhat.com> <4EA81BB2.90904@redhat.com> <4EA82120.8060702@siemens.com> <4EA82395.20408@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , "agraf@suse.de" , "Dr. David Alan Gilbert" , "qemu-devel@nongnu.org" , "patches@linaro.org" On 2011-10-26 17:18, Peter Maydell wrote: > On 26 October 2011 16:13, Jan Kiszka wrote: >> My point is that it is fine to use for per-vcpu variables because: >> - they are single-threaded in TCG mode >> - they are multi-threaded in KVM mode, but that's only affecting Linux >> hosts for which this TLS wrapper is already usable > > Oh, I see. Feel free to suggest reworded comment text :-) /* Dummy implementations -- we can get away with this because * - we confine the use to per-VCPU variables * - only linux-user supports multiple VCPU threads * - TCG system mode is single-threaded regarding VCPUs * - KVM system mode is multi-threaded but limited to Linux OK? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux