From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] NS16550: buffer reads
Date: Wed, 26 Oct 2011 11:55:36 -0500 [thread overview]
Message-ID: <4EA83B88.8040109@freescale.com> (raw)
In-Reply-To: <CALButCK2XnZ=HR72VaXioCfxkMFgMh2JbXzSDq9TadgKFH52rQ@mail.gmail.com>
On 10/25/2011 06:37 PM, Graeme Russ wrote:
> Hi Simon,
>
> On Wed, Oct 26, 2011 at 10:17 AM, Simon Glass <sjg@chromium.org> wrote:
>
> [big snip]
>
>> Did I mention a can of worms? After 65 messages on this topic Scott's
>> patch seems pretty appealing right now! We can even move it up a level
>> in the s/w stack if that helps.
>
> But I agree with Wolfgang that Scott's proposal only hides the real
> problem even deeper and will make a real solution more difficult
> next time around
Even in Linux you can get loss if you overflow the kernel's buffer.
Flow control is just not that commonly used in this sort of application.
If we insist on software flow control for U-Boot to get any usable
multi-line pasting to work, the user has to reconfigure their terminal
software for this -- it would take some effort for me to figure out how
to do that on our board farm serial server. And maybe that's not the
right setting for what the user wants to do with the port later on.
Someone also raised the issue of TX buffering -- and you replied that it
should be turned off if hardware flow control is not used. This is not
what happens in Linux, at least, and we should not be depending in
U-Boot on the other end not using TX buffers.
The point here is to make an incremental improvement that solves a
problem for some people (even if not "solving" the general problem),
without significant impact elsewhere. The minor size increase when the
option is not enabled can be fixed. See previous discussion:
http://lists.denx.de/pipermail/u-boot/2011-April/089878.html
If someone wants to further improve things by adding optional interrupt
support or flow control, I don't see how this patch makes that more
difficult.
-Scott
next prev parent reply other threads:[~2011-10-26 16:55 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 5:14 [U-Boot] [PATCH v4 1/2] NS16550: trivial code clean for checkpatch Simon Glass
2011-10-16 5:14 ` [U-Boot] [PATCH v4 2/2] NS16550: buffer reads Simon Glass
2011-10-16 12:57 ` Albert ARIBAUD
2011-10-16 17:06 ` Simon Glass
2011-10-16 20:13 ` Wolfgang Denk
2011-10-16 20:47 ` Simon Glass
2011-10-16 21:03 ` Wolfgang Denk
2011-10-17 11:08 ` Wolfgang Denk
2011-10-17 16:25 ` Simon Glass
2011-10-17 20:19 ` Simon Glass
2011-10-17 20:33 ` Wolfgang Denk
2011-10-17 20:58 ` Simon Glass
2011-10-22 8:29 ` Albert ARIBAUD
2011-10-17 12:18 ` Wolfgang Denk
2011-10-17 16:40 ` Simon Glass
2011-10-22 8:44 ` Albert ARIBAUD
2011-10-22 22:15 ` Graeme Russ
2011-10-23 8:20 ` Wolfgang Denk
2011-10-23 11:50 ` Graeme Russ
2011-10-23 17:15 ` Wolfgang Denk
2011-10-23 20:17 ` Graeme Russ
2011-10-23 21:22 ` Wolfgang Denk
2011-10-23 21:32 ` [U-Boot] [PATCH v2] " Graeme Russ
2011-10-23 22:18 ` Wolfgang Denk
2011-10-23 23:30 ` Graeme Russ
2011-10-24 4:47 ` Simon Glass
2011-10-24 18:46 ` Wolfgang Denk
2011-10-24 19:26 ` Graeme Russ
2011-10-24 20:00 ` Wolfgang Denk
2011-10-24 20:40 ` Graeme Russ
2011-10-24 21:59 ` Wolfgang Denk
2011-10-24 22:22 ` Graeme Russ
2011-10-24 23:31 ` J. William Campbell
2011-10-25 7:31 ` Wolfgang Denk
2011-10-25 8:34 ` Graeme Russ
2011-10-25 18:41 ` Wolfgang Denk
2011-10-25 22:37 ` Graeme Russ
2011-10-25 23:17 ` Simon Glass
[not found] ` <CALButCK2XnZ=HR72VaXioCfxkMFgMh2JbXzSDq9TadgKFH52rQ@mail.gmail.com >
2011-10-25 23:37 ` Graeme Russ
2011-10-25 23:48 ` Simon Glass
2011-10-26 3:41 ` Graeme Russ
2011-10-26 7:00 ` Wolfgang Denk
2011-10-26 9:18 ` Graeme Russ
2011-10-26 10:19 ` Wolfgang Denk
2011-10-26 16:55 ` Scott Wood [this message]
2011-10-26 18:17 ` Wolfgang Denk
2011-10-26 18:50 ` Scott Wood
2011-10-26 19:19 ` Wolfgang Denk
2011-10-26 6:54 ` Wolfgang Denk
2011-10-23 18:17 ` [U-Boot] [PATCH v4 2/2] " Wolfgang Denk
2011-10-23 18:20 ` [U-Boot] [PATCH v4 1/2] NS16550: trivial code clean for checkpatch Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2011-10-15 0:03 [U-Boot] [PATCH v2] NS16550: buffer reads Simon Glass
2011-10-15 10:43 ` Albert ARIBAUD
2011-10-15 14:47 ` Simon Glass
2011-10-15 16:02 ` Wolfgang Denk
2011-10-15 16:12 ` Simon Glass
2011-10-15 16:21 ` Albert ARIBAUD
2011-10-15 16:50 ` Simon Glass
2011-10-15 17:45 ` Simon Glass
2011-10-15 19:14 ` Wolfgang Denk
2011-10-16 4:46 ` Simon Glass
2011-10-16 19:52 ` Wolfgang Denk
2011-10-16 21:02 ` Simon Glass
2011-10-15 19:05 ` Wolfgang Denk
2011-10-15 19:00 ` Wolfgang Denk
2011-10-16 4:39 ` Simon Glass
2011-10-16 19:47 ` Wolfgang Denk
2011-10-16 20:43 ` Simon Glass
2011-10-16 21:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA83B88.8040109@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.