All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arne Jansen <sensille@gmx.net>
To: Chris Mason <chris.mason@oracle.com>,
	Peeters Simon <peeters.simon@gmail.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [patch] Move nodesize/leafsize/sectorsize to fs_info
Date: Wed, 26 Oct 2011 22:54:10 +0200	[thread overview]
Message-ID: <4EA87372.5050006@gmx.net> (raw)
In-Reply-To: <20111026162719.GC5177@shiny.Mikenopa.local>

On 10/26/2011 06:27 PM, Chris Mason wrote:
> On Wed, Oct 26, 2011 at 06:23:38PM +0200, David Sterba wrote:
>> On Wed, Oct 26, 2011 at 04:47:15PM +0200, Arne Jansen wrote:
>>> The sizes get initialized to 4096, but after the super block is read,
>>> these are replaced by those from the SB.
>>
>> [reads sources again] right, and the initial values are not used up to
>> that point, so 4096 could be any number.
>>
>>> It was indeed meant to get rid of the possibility to have different
>>> sizes for different trees, as it just adds complexity. Chris mentioned
>>> once that he does not intend to allow different sizes between trees,
>>> thus the idea for this cleanup.
>>
>> Ok then. I'll gather it to cleanup patch queue.
>
> Thanks, I actually don't intend to allow different leaf and node sizes
> anymore either, but we might as well keep both numbers.

So that would be another good cleanup, as it is not always easy to tell
if a block is a node or a leaf. It would actually simplify things.

-Arne

>
> -chris
>

  reply	other threads:[~2011-10-26 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-07 21:54 [patch] Move nodesize/leafsize/sectorsize to fs_info Peeters Simon
2011-10-26 13:34 ` David Sterba
2011-10-26 14:47   ` Arne Jansen
2011-10-26 16:23     ` David Sterba
2011-10-26 16:27       ` Chris Mason
2011-10-26 20:54         ` Arne Jansen [this message]
2011-10-31 13:51 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA87372.5050006@gmx.net \
    --to=sensille@gmx.net \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=peeters.simon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.